Skip to content

sort oc projects alphabetically#9675

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
juanvallejo:jvallejo_sort-oc-projects-output
Jul 2, 2016
Merged

sort oc projects alphabetically#9675
openshift-bot merged 1 commit intoopenshift:masterfrom
juanvallejo:jvallejo_sort-oc-projects-output

Conversation

@juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Jul 1, 2016 •
edited
Loading

Fixes #9667

$ oc projects
You have access to the following projects and can switch between them with 'oc project <projectname>':

  * aaaa
    default
    openshift
    openshift-infra
    testproject
    zzzz

Using project "aaaa" on server "https://10.13.137.149:8443".

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Jul 1, 2016

@fabianofranz @Kargakis Could you take a look please?

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Jul 1, 2016

[test]

@juanvallejo juanvallejo mentioned this pull request Jul 1, 2016
Closed
@fabianofranz
Copy link
Member

fabianofranz commented Jul 1, 2016

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5734/) (Image: devenv-rhel7_4511)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2016

Evaluated for origin merge up to 3286bfd

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Jul 1, 2016

flake re[test]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2016

Evaluated for origin test up to 3286bfd

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2016

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5706/)

@fabianofranz
Copy link
Member

fabianofranz commented Jul 1, 2016

[merge]

@openshift-bot openshift-bot merged commit f88a3ae into openshift:master Jul 2, 2016
soltysh
soltysh reviewed Jul 4, 2016
View reviewed changes
pkg/cmd/cli/cmd/projects.go
var currentProjectExists bool = false
var currentProjectErr error = nil
var currentProjectExists bool
var currentProjectErr error
Copy link
Contributor

@soltysh soltysh Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the future, prefer using: currentProjectExists := nil than this, because it immediately gives you the default value of a variable and it's less typing ;) Besides if you have two or more vars use block declaration:

var (
    currentProjectExists bool
    currentProjectErr error
)

Copy link
Contributor

@0xmichalis 0xmichalis Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

currentProjectExists := nil

Won't this throw an error or something?

Copy link
Contributor

@soltysh soltysh Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True it will, since it does not know the type. My bad.

@juanvallejo juanvallejo deleted the jvallejo_sort-oc-projects-output branch July 5, 2016 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juanvallejo @fabianofranz @openshift-bot @soltysh @0xmichalis