Skip to content

CLI: command to set deployment hooks on deployment configs#9187

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
csrwng:set_deplhook
Jun 9, 2016
Merged

CLI: command to set deployment hooks on deployment configs#9187
openshift-bot merged 1 commit intoopenshift:masterfrom
csrwng:set_deplhook

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Jun 6, 2016

'oc set deployment-hook' command
Implements #9040

@csrwng
Copy link
Contributor Author

csrwng commented Jun 6, 2016

@bparees ptal

%[1]s deployment-hook dc/myapp --pre -v data -- /var/lib/migrate-db.sh

# Set a mid deployment hook along with additional environment variables
%[1]s deployment-hook dc/myapp --mid -v data -e VAR1=value1,VAR2=value2 -- /var/lib/prepare-deploy.sh`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we were moving away from comma separated env variables and moving to mulitple -e args instead?

@csrwng csrwng force-pushed the set_deplhook branch 2 times, most recently from 03be1d3 to 944a767 Compare June 7, 2016 11:53
@csrwng
Copy link
Contributor Author

csrwng commented Jun 7, 2016

updated

@csrwng csrwng force-pushed the set_deplhook branch 3 times, most recently from e44eed4 to 3a5accb Compare June 7, 2016 13:53
@csrwng
Copy link
Contributor Author

csrwng commented Jun 7, 2016

[test]

@csrwng
Copy link
Contributor Author

csrwng commented Jun 8, 2016

@openshift/api-review

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e8c6533

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4663/)

@bparees
Copy link
Contributor

bparees commented Jun 9, 2016

lgtm [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4663/) (Image: devenv-rhel7_4342)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e8c6533

@openshift-bot openshift-bot merged commit 6296cea into openshift:master Jun 9, 2016
@csrwng csrwng deleted the set_deplhook branch July 19, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants