add cli describer for oauthtokens by juanvallejo · Pull Request #9032 · openshift/origin

juanvallejo · 2016-05-25T21:21:29Z

Adds a command line describer for OAuth tokens:
oc describe oauthaccesstoken <token-name>

Name:           <token-name>
Namespace:      <none>
Created:        2 hours ago
Labels:         <none>
Annotations:    <none>
Scopes:         []
Expires In:     24 hours
User Name:      test
User UID:       322b236b-22b9-11e6-b307-080027242396
Refresh Token:  <none>
Client Name:    openshift-challenging-client

fixes #9012

deads2k · 2016-05-26T12:00:32Z

pkg/cmd/cli/describe/describer.go

+		formatMeta(out, oAuthAccessToken.ObjectMeta)
+		formatString(out, "Client Name", oAuthAccessToken.ClientName)
+		formatString(out, "Expires In", oAuthAccessToken.ExpiresIn)
+		formatString(out, "Redirect URI", oAuthAccessToken.RedirectURI)


i don't think this value is very useful. The redirect already happened and someone doing a post-mortem on a token will have the json.

deads2k · 2016-05-26T12:07:03Z

Looks good, the output just needs a little swizzling.

juanvallejo · 2016-05-26T17:18:46Z

Updated output:

oc describe oauthaccesstoken <token-name>

Name:           <token-name>
Namespace:      <none>
Created:        2 hours ago
Labels:         <none>
Annotations:    <none>
Scopes:         []
Expires In:     24 hours
User Name:      test
User UID:       322b236b-22b9-11e6-b307-080027242396
Refresh Token:  <none>
Client Name:    openshift-challenging-client

liggitt · 2016-05-26T17:19:56Z

expires in should either be an absolute date, or relative to the current time

deads2k · 2016-05-26T17:40:59Z

expires in should either be an absolute date, or relative to the current time

Do you happen to know the answer to my question; #9032 (comment) ?

deads2k · 2016-05-26T17:42:48Z

@juanvallejo found it . FormatRelativeTime

juanvallejo · 2016-05-26T21:18:15Z

Updated expiration time to absolute date (helper functions that we have fail to correctly handle a time difference longer than 24h so not using FormatRelativeTime for now, I will submit another pull request addressing this).

Updated console output:

oc describe oauthaccesstoken <token-name>

Name:           <token-name>
Namespace:      <none>
Created:        6 hours ago
Labels:         <none>
Annotations:    <none>
Scopes:         []
Expires:        May 27, 14:37 +0000 UTC
User Name:      test
User UID:       322b236b-22b9-11e6-b307-080027242396
Refresh Token:  <none>
Client Name:    openshift-challenging-client

juanvallejo · 2016-05-27T02:44:51Z

@deads2k
Updated console output:

oc describe oauthaccesstoken <token-name>

Name:           <token-name>
Namespace:      <none>
Created:        11 hours ago
Labels:         <none>
Annotations:    <none>
Scopes:         []
Expires In:     12 hours
User Name:      test
User UID:       322b236b-22b9-11e6-b307-080027242396
Refresh Token:  <none>
Client Name:    openshift-challenging-client

deads2k · 2016-05-27T17:02:48Z

pkg/cmd/cli/describe/describer.go

+		formatString(out, "Expires In", formatToHumanDuration(timeExpired.Sub(time.Now())))
+		formatString(out, "User Name", oAuthAccessToken.UserName)
+		formatString(out, "User UID", oAuthAccessToken.UserUID)
+		formatString(out, "Refresh Token", oAuthAccessToken.RefreshToken)


We don't provide these yet. Remove this line.

deads2k · 2016-05-27T17:07:22Z

Can you show me an example 6 months in the future?

deads2k · 2016-05-27T17:07:59Z

pkg/cmd/cli/describe/helpers.go

 	return time.Now()
 }

+func TimeNowFn() time.Time {


Why are you exposing this?

juanvallejo · 2016-05-27T19:17:55Z

@deads2k Output on token with expiration date 6months in the future:

oc describe oauthaccesstoken DYGZDLucARCPIfUeKPhsgPfn0WBLR_9KdeREH0c9ioc

Name:           DYGZDLucARCPIfUeKPhsgPfn0WBLR_9KdeREH0c9ioc
Namespace:      <none>
Created:        13 minutes ago
Labels:         <none>
Annotations:    <none>
Scopes:         []
Expires In:     5 months
User Name:      test
User UID:       322b236b-22b9-11e6-b307-080027242396
Client Name:    openshift-challenging-client

deads2k · 2016-05-27T19:26:29Z

@deads2k Output on token with expiration date 6months in the future:

Ok, go ahead and squash down

deads2k · 2016-05-27T19:27:14Z

test/fixtures/oauthaccesstoken.yaml

+  creationTimestamp: 2016-05-27T15:06:11Z
+  deletionTimestamp: 2016-11-28T15:06:11Z
+  name: DYGZDLucARCPIfUeKPhsgPfn0WBLR_9KdeREH0c9iod
+  resourceVersion: "5338"


remove creation,deleteion,resourceversion,selflink,uid

juanvallejo · 2016-05-27T20:05:14Z

@deads2k Okay, revised test/fixtures/oauthaccesstoken.yaml and squashed down

deads2k · 2016-05-27T20:34:02Z

lgtm [merge]

openshift-bot · 2016-05-27T20:35:23Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4176/) (Image: devenv-rhel7_4293)

openshift-bot · 2016-05-27T20:35:23Z

Evaluated for origin merge up to a353593

openshift-bot · 2016-05-27T20:35:24Z

[Test]ing while waiting on the merge queue

openshift-bot · 2016-05-27T20:40:23Z

Evaluated for origin test up to a353593

openshift-bot · 2016-05-27T21:48:10Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4167/)

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2016

deads2k reviewed May 26, 2016
View reviewed changes

stevekuznetsov assigned deads2k May 26, 2016

stevekuznetsov added kind/enhancement component/cli area/usability labels May 26, 2016

juanvallejo force-pushed the jvallejo_add-cli-oauth-describer branch from 9bc0497 to d15b954 Compare May 26, 2016 17:09

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2016

deads2k reviewed May 27, 2016
View reviewed changes

pkg/cmd/cli/describe/helpers.go Outdated

return time.Now()

}

func TimeNowFn() time.Time {

Copy link

Contributor

deads2k May 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you exposing this?

deads2k reviewed May 27, 2016
View reviewed changes

add cli describer for oauthtokens

a353593

juanvallejo force-pushed the jvallejo_add-cli-oauth-describer branch from 0d3243d to a353593 Compare May 27, 2016 20:02

openshift-bot merged commit de8130a into openshift:master May 28, 2016

juanvallejo deleted the jvallejo_add-cli-oauth-describer branch May 31, 2016 13:33

Conversation

juanvallejo commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deads2k May 26, 2016

Choose a reason for hiding this comment

Uh oh!

deads2k commented May 26, 2016

Uh oh!

juanvallejo commented May 26, 2016

Uh oh!

liggitt commented May 26, 2016

Uh oh!

deads2k commented May 26, 2016

Uh oh!

deads2k commented May 26, 2016

Uh oh!

juanvallejo commented May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juanvallejo commented May 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deads2k May 27, 2016

Choose a reason for hiding this comment

Uh oh!

deads2k commented May 27, 2016

Uh oh!

deads2k May 27, 2016

Choose a reason for hiding this comment

Uh oh!

juanvallejo commented May 27, 2016

Uh oh!

deads2k commented May 27, 2016

Uh oh!

deads2k May 27, 2016

Choose a reason for hiding this comment

Uh oh!

juanvallejo commented May 27, 2016

Uh oh!

deads2k commented May 27, 2016

Uh oh!

openshift-bot commented May 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented May 27, 2016

Uh oh!

openshift-bot commented May 27, 2016

Uh oh!

openshift-bot commented May 27, 2016

Uh oh!

openshift-bot commented May 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

juanvallejo commented May 25, 2016 •

edited

Loading

juanvallejo commented May 26, 2016 •

edited

Loading

juanvallejo commented May 27, 2016 •

edited

Loading

openshift-bot commented May 27, 2016 •

edited

Loading