Wait until user has access to project in extended#8585
Wait until user has access to project in extended#8585openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Prevents flakes where CLI can't run.
smarterclayton
force-pushed
the
retry_test_acl
branch
from
4fac579 to
577972c
Compare
|
[test] On Thu, Apr 21, 2016 at 1:20 PM, OpenShift Bot notifications@github.com
|
| e2e.Logf("Failed to create a project and namespace %q: %v", c.Namespace(), err) | ||
| return nil, err | ||
| } | ||
| if err := wait.ExponentialBackoff(kclient.DefaultBackoff, func() (bool, error) { |
There was a problem hiding this comment.
Ick. https://github.com/openshift/origin/blob/master/test/util/policy.go#L20. Even a copy/paste would be preferable.
There was a problem hiding this comment.
I'll need to cut and paste because integration package loads etcd. Also, I
don't want to poll, I want to backoff.
On Thu, Apr 21, 2016 at 3:50 PM, David Eads notifications@github.com
wrote:
In test/extended/util/cli.go
#8585 (comment):@@ -148,6 +150,17 @@ func (c *CLI) SetupProject(name string, kubeClient *kclient.Client, _ map[string
e2e.Logf("Failed to create a project and namespace %q: %v", c.Namespace(), err)
return nil, err
}
- if err := wait.ExponentialBackoff(kclient.DefaultBackoff, func() (bool, error) {
Ick.
https://github.com/openshift/origin/blob/master/test/util/policy.go#L20.
Even a copy/paste would be preferable.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/8585/files/577972ccdb7de74c7cee66c1aff7f57050fc4f5d#r60644156
There was a problem hiding this comment.
We should have a helper to create a SAR condition "CanI"
On Thu, Apr 21, 2016 at 6:26 PM, Clayton Coleman ccoleman@redhat.com
wrote:
I'll need to cut and paste because integration package loads etcd. Also,
I don't want to poll, I want to backoff.On Thu, Apr 21, 2016 at 3:50 PM, David Eads notifications@github.com
wrote:In test/extended/util/cli.go
#8585 (comment):@@ -148,6 +150,17 @@ func (c *CLI) SetupProject(name string, kubeClient *kclient.Client, _ map[string
e2e.Logf("Failed to create a project and namespace %q: %v", c.Namespace(), err)
return nil, err
}
- if err := wait.ExponentialBackoff(kclient.DefaultBackoff, func() (bool, error) {
Ick.
https://github.com/openshift/origin/blob/master/test/util/policy.go#L20.
Even a copy/paste would be preferable.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/8585/files/577972ccdb7de74c7cee66c1aff7f57050fc4f5d#r60644156
|
[test] |
1 similar comment
|
[test] |
|
Evaluated for origin test up to 577972c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3199/) |
|
[merge] for less flakes |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5666/) (Image: devenv-rhel7_4018) |
|
Evaluated for origin merge up to 577972c |
3 participants
Prevents flakes where CLI can't run.
Fixes #8491
[test]