Retry import from the DockerHub on 401#8574
Conversation
|
[test] |
|
LGTM, merge as soon as tests are green. |
|
We're going to hold off on this for 1.2 just because of risk. |
|
[test] |
|
Flaked on #8491 [test] On Wed, Apr 20, 2016 at 1:40 PM, OpenShift Bot notifications@github.com
|
|
[test] |
|
Adding a workaround for the legacy client (it's less work than ripping out On Wed, Apr 20, 2016 at 2:46 PM, OpenShift Bot notifications@github.com
|
|
role assignment flake On Wed, Apr 20, 2016 at 7:00 PM, OpenShift Bot notifications@github.com
|
|
[test] |
DockerHub generates JWT tokens that are valid from "now", which means fast actions can get a 401 unauthorized if the second boundary on the hub servers is not aligned. We retry 401 unauthorized requests immediately (one time), then wait a small window of time before retrying. If our operation is too slow (longer than the window) we do not retry. Probably an issue with Docker Trusted Registries as well.
smarterclayton
force-pushed
the
retry_import
branch
from
cbf01da to
8faa82f
Compare
|
Evaluated for origin test up to 8faa82f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3163/) |
|
Additional changes LGTM. |
|
Given that flakes are blocking final merges, I'm merging this (we've had a lot of soak time). [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5661/) (Image: devenv-rhel7_4014) |
|
Flake #8606 [merge] On Fri, Apr 22, 2016 at 12:40 PM, OpenShift Bot notifications@github.com
|
|
Evaluated for origin merge up to 8faa82f |
3 participants
Follow on to #8558
Fixes #7429 #8399 #8444