Skip to content

[DO NOT MERGE] Run SDN after Proxy to ensure correct bridge-nf-call-iptables value#6686

Closed
dcbw wants to merge 1 commit intoopenshift:masterfrom
dcbw:sdn-proxy-nf-call-iptables
Closed

[DO NOT MERGE] Run SDN after Proxy to ensure correct bridge-nf-call-iptables value#6686
dcbw wants to merge 1 commit intoopenshift:masterfrom
dcbw:sdn-proxy-nf-call-iptables

Conversation

@dcbw
Copy link
Contributor

@dcbw dcbw commented Jan 15, 2016

@dcbw
Copy link
Contributor Author

dcbw commented Jan 15, 2016

[testonlyextended][extended:networking]

@openshift-bot
Copy link
Contributor

Evaluated for origin testonlyextended up to 4227b5b

@liggitt
Copy link
Contributor

liggitt commented Jan 15, 2016

Aren't all of those async? Changing the order doesn't seem like it would reliably fix the issue.

@dcbw
Copy link
Contributor Author

dcbw commented Jan 15, 2016

@liggitt The pieces of SDN and the Proxy that are in conflict are actually synchronous.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testonlyextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/47/) (Extended Tests: networking)

@dcbw
Copy link
Contributor Author

dcbw commented Jan 15, 2016

[test][extended]

@dcbw
Copy link
Contributor Author

dcbw commented Jan 15, 2016

@liggitt I've got another openshift-sdn bump to fix one issue that I found while fixing this, but I want to make sure the reorder passes all the tests before I submit that openshift-sdn bump with this PR. And unfortunately we need sort out #6684 first.

@eparis
Copy link
Member

eparis commented Jan 16, 2016

I (double) checked and the two calls are definitely in synchronous code paths. Assuming this tests out ok, it LGTM.

@dcbw
Copy link
Contributor Author

dcbw commented Jan 16, 2016

Filed as #6687

extended test failure appears to be a flake:

panic: test timed out after 1m0s

goroutine 43 [running]:
testing.func·008()
/usr/lib/golang/src/testing/testing.go:681 +0x168
created by time.goFunc
/usr/lib/golang/src/time/sleep.go:129 +0x59

goroutine 1 [chan receive]:
testing.RunTests(0x19b2d60, 0x204b260, 0x2, 0x2, 0xc208059e01)
/usr/lib/golang/src/testing/testing.go:556 +0xdc3
testing.(*M).Run(0xc208179720, 0x2a015e0)
/usr/lib/golang/src/testing/testing.go:485 +0xe1
main.main()
github.com/openshift/origin/pkg/cmd/server/admin/_test/_testmain.go:126 +0x382

goroutine 9 [syscall, 1 minutes]:
os/signal.loop()
/usr/lib/golang/src/os/signal/signal_unix.go:21 +0x2d
created by os/signal.init·1
/usr/lib/golang/src/os/signal/signal_unix.go:27 +0x43

goroutine 42 [runnable]:
math/big.nat.norm(0xc2084c5400, 0x11, 0x25, 0xc20818b0e0, 0x21, 0x24)
/usr/lib/golang/src/math/big/nat.go:61
math/big.nat.divLarge(0xc2084c5400, 0x10, 0x25, 0xc20818b0e0, 0x21, 0x24, 0xc20818afc0, 0x20, 0x24, 0xc2082ee000, ...)
/usr/lib/golang/src/math/big/nat.go:594 +0xfa0
math/big.nat.div(0xc2084c5400, 0x10, 0x25, 0xc20818b0e0, 0x20, 0x24, 0xc20818afc0, 0x20, 0x24, 0xc2082ee000, ...)

which looks like our AWS instances just take too long to run crypto/rsa.GenerateMultiPrimeKey()

@dcbw
Copy link
Contributor Author

dcbw commented Jan 16, 2016

[test][extended]

@dcbw
Copy link
Contributor Author

dcbw commented Jan 16, 2016

It turns out re-ordering isn't safe for the multitenant plugin, so we'll work around this another way.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/51/) (Extended Tests: networking)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4227b5b

@dcbw
Copy link
Contributor Author

dcbw commented Jan 16, 2016

@danwinship will take it from here with a different patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants