[DO NOT MERGE] Run SDN after Proxy to ensure correct bridge-nf-call-iptables value#6686
[DO NOT MERGE] Run SDN after Proxy to ensure correct bridge-nf-call-iptables value#6686dcbw wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[testonlyextended][extended:networking] |
|
Evaluated for origin testonlyextended up to 4227b5b |
|
Aren't all of those async? Changing the order doesn't seem like it would reliably fix the issue. |
|
@liggitt The pieces of SDN and the Proxy that are in conflict are actually synchronous. |
|
continuous-integration/openshift-jenkins/testonlyextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/47/) (Extended Tests: networking) |
|
[test][extended] |
|
I (double) checked and the two calls are definitely in synchronous code paths. Assuming this tests out ok, it LGTM. |
|
Filed as #6687 extended test failure appears to be a flake: panic: test timed out after 1m0s goroutine 43 [running]: goroutine 1 [chan receive]: goroutine 9 [syscall, 1 minutes]: goroutine 42 [runnable]: which looks like our AWS instances just take too long to run crypto/rsa.GenerateMultiPrimeKey() |
|
[test][extended] |
|
It turns out re-ordering isn't safe for the multitenant plugin, so we'll work around this another way. |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/51/) (Extended Tests: networking) |
|
Evaluated for origin test up to 4227b5b |
|
@danwinship will take it from here with a different patch. |
https://bugzilla.redhat.com/show_bug.cgi?id=1294061