Skip to content

Minor fixup to egress IP monitoring#21087

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.10from
danwinship:egressip-fixes-3.10
Sep 24, 2018
Merged

Minor fixup to egress IP monitoring#21087
openshift-merge-robot merged 1 commit intoopenshift:release-3.10from
danwinship:egressip-fixes-3.10

Conversation

@danwinship
Copy link
Contributor

Backport of #20733.

(I had thought there were going to be other backports but none of the other 3.11 stuff applies to 3.10. In particular, #20950 does not affect the semi-automatic-HA case because we don't even look at the result of the "ping" in the semi-automatic case, we only look at whether it resulted in both the "in" and "out" counters in OVS going up.)

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b497d5b into openshift:release-3.10 Sep 24, 2018
@danwinship danwinship deleted the egressip-fixes-3.10 branch January 31, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/networking lgtm Indicates that a PR is ready to be merged. sig/networking size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants