UPSTREAM: <drop>: increase loglevel for health check#20616
UPSTREAM: <drop>: increase loglevel for health check#20616openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
size/XS
|
/retest |
|
/hold the point of the health check is to detect hung output. to detect that, we need to do something that triggers glog.Flush(). https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/healthz/healthz.go#L75-L89 would be a better way to do this. |
openshift-ci-robot
added
the
do-not-merge/hold
mfojtik
force-pushed
the
upstream-healthz
branch
from
2c24f83 to
b7a7130
Compare
openshift-ci-robot
added
size/M
|
@liggitt fixed, thanks! |
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
@liggitt i don't see this in current upstream nor in 1.11 branch. Do we carry this in rebase ?
Fixes: http://bugzilla.redhat.com/show_bug.cgi?id=1608109
/cc @smarterclayton