UPSTREAM: <carry>: ensure perFSGroup quantity is positive#20564
UPSTREAM: <carry>: ensure perFSGroup quantity is positive#20564openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
sjenning
changed the title
| return fmt.Errorf("unable to parse \"%s\" as a quantity", volumeConfig.LocalQuota.PerFSGroup) | ||
| } | ||
|
|
||
| if quota.Value() <= 0 { |
There was a problem hiding this comment.
Is perFSGroup able to be set to 0? Then this comparison would be < 0. Just double checking
There was a problem hiding this comment.
Basically that would make all of the emptydirs effectively read-only and.. well.. permanently empty. So that didn't seem like something someone would ever want in my mind. Granted, you could set it to 1 bytes and probably be in the same boat but if you set a non-zero lower limit, you'd have to document it and I didn't want to do that 😄
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, rphillips, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
5 participants
xref https://bugzilla.redhat.com/show_bug.cgi?id=1594144
@derekwaynecarr