Fix debug panic#20550
Conversation
openshift-ci-robot
added
the
size/M
|
/retest |
juanvallejo
force-pushed
the
jvallejo/fix-debug-panic
branch
from
0f0f2bf to
55db6b5
Compare
openshift-ci-robot
added
size/L
juanvallejo
force-pushed
the
jvallejo/fix-debug-panic
branch
from
55db6b5 to
82db1ef
Compare
pkg/oc/cli/debug/debug.go
Outdated
|
|
||
| // podContainerRunning returns false until the named container has ContainerStatus running (at least once), | ||
| // and will return an error if the pod is deleted, runs to completion, or the container pod is not available. | ||
| func podContainerRunning(containerName string) watch.ConditionFunc { |
There was a problem hiding this comment.
are these the same? oc/lib/conditions
There was a problem hiding this comment.
Thanks, moved this helper to the oc/lib/conditions package
juanvallejo
force-pushed
the
jvallejo/fix-debug-panic
branch
from
82db1ef to
0e8193e
Compare
|
/test extended_clusterup |
|
/retest |
|
/test gcp |
|
|
||
| // podContainerRunning returns false until the named container has ContainerStatus running (at least once), | ||
| // and will return an error if the pod is deleted, runs to completion, or the container pod is not available. | ||
| func podContainerRunning(containerName string) watch.ConditionFunc { |
There was a problem hiding this comment.
@deads2k this is a copy of the helper under oc/lib/conditions. This diagnostics file deals with internalversions, and we'll be removing diagnostics soon anyway, so I figured we could leave this copy here until then
|
/retest |
|
/test gcp |
2 similar comments
|
/test gcp |
|
/test gcp |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
6 participants
Debug was creating and using kcmd.LogOptions without passing a "consumeRequest" func and a RESTClientGetter
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1612661
cc @deads2k @soltysh