avoid unnecessary admission plugin initializers#20491
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Aug 1, 2018
Merged
avoid unnecessary admission plugin initializers#20491openshift-merge-robot merged 3 commits intoopenshift:masterfrom
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-bot
added
the
needs-rebase
Contributor
|
LGTM, freel free to tag after resolving conflicts |
deads2k
force-pushed
the
server-05-admission-shrink
branch
from
86bdfef to
fe968dd
Compare
openshift-bot
removed
the
needs-rebase
deads2k
force-pushed
the
server-05-admission-shrink
branch
from
fe968dd to
464b4d9
Compare
deads2k
force-pushed
the
server-05-admission-shrink
branch
from
464b4d9 to
c3f9477
Compare
|
New changes are detected. LGTM label has been removed. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes most of our plugin initializers by building clients in the admission plugins themselves and switching to upstream initializers and external types. It also fixes some names which had fallen out of sync.
@mfojtik