Update commands with resource builders to use external versions by juanvallejo · Pull Request #20400 · openshift/origin

juanvallejo · 2018-07-23T19:51:47Z

Updates any remaining commands that use resource builders to deal with external versions

juanvallejo · 2018-07-23T20:52:40Z

pkg/oc/cli/debug/debug.go

 	o.Builder = f.NewBuilder

+	// TODO: not sure what to do with this helper - new duplicate for external versions?
 	o.AddEnv, o.RemoveEnv, err = utilenv.ParseEnv(envArgs, nil)


@deads2k @soltysh still not sure what to do with this helper, duplicate it to deal with externals? - it depends on other env utils

See https://github.com/openshift/origin/pull/20382/files#r204804974

juanvallejo · 2018-07-23T20:53:11Z

pkg/oc/cli/debug/debug.go

 	}

+	// TODO: DockerImageMetadata is a RawExtension in the external api - how to access config?
 	if image == nil || image.DockerImageMetadata.Config == nil {


@deads2k @soltysh Not sure how to access config here - DockerImageMetadata is a RawExtension in the external api

juanvallejo · 2018-07-24T14:24:10Z

cc @deads2k @soltysh

juanvallejo · 2018-07-25T14:57:29Z

pkg/oc/cli/debug/debug.go

+	// TODO: find a way to do this with the external api
+	// convert image to internal in order to extract its imagemetadata config
+	internalImage := &internalimage.Image{}
+	if err := oapiv1.Convert_v1_Image_To_image_Image(image, internalImage, nil); err != nil {


@deads2k Is there a more elegant way to access an image's DockerImageMetadata.Config field? The external api stores the DockerImageMetadata field as a RawExtension

We'll have to live with it for now.

juanvallejo · 2018-07-31T14:42:48Z

/retest

openshift-ci-robot · 2018-08-01T02:12:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~contrib/completions/OWNERS~~ [juanvallejo]
hack/OWNERS
pkg/image/OWNERS
pkg/oc/OWNERS
vendor/k8s.io/kubernetes/pkg/OWNERS
vendor/k8s.io/kubernetes/test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2018-08-02T04:29:50Z

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/end_to_end	`8a8b443`	link	`/test end_to_end`
ci/openshift-jenkins/extended_clusterup	`8a8b443`	link	`/test extended_clusterup`
ci/openshift-jenkins/cmd	`8a8b443`	link	`/test cmd`
ci/prow/gcp	`8a8b443`	link	`/test gcp`
ci/openshift-jenkins/extended_conformance_install	`8a8b443`	link	`/test extended_conformance_install`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh · 2018-08-02T11:46:19Z

pkg/oc/cli/secrets/dockercfg.go

-	if _, err := o.SecretsInterface.Create(secret); err != nil {
-		return err
-	}
+	// TODO: sweep codebase removing implied --dry-run behavior when -o is specified


@juanvallejo create an issue about it.

soltysh · 2018-08-02T12:08:46Z

Closed in favor of #20514.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2018

openshift-ci-robot requested review from enj and soltysh July 23, 2018 19:51

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2018

juanvallejo commented Jul 23, 2018

View reviewed changes

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from ceb15f9 to 3aabb30 Compare July 23, 2018 22:10

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2018

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from 3aabb30 to a32fc18 Compare July 23, 2018 22:44

soltysh mentioned this pull request Jul 24, 2018

make startbuild command external #20382

Merged

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 2 times, most recently from 9c2cad7 to 130c684 Compare July 25, 2018 14:53

juanvallejo changed the title ~~[WIP] Update commands with resource builders to use external versions~~ Update commands with resource builders to use external versions Jul 25, 2018

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2018

juanvallejo commented Jul 25, 2018

View reviewed changes

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from 130c684 to 3883384 Compare July 25, 2018 22:00

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2018

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 2 times, most recently from 117694b to b86760e Compare July 25, 2018 22:58

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2018

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from b86760e to e26a263 Compare July 26, 2018 18:05

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2018

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 3 times, most recently from 7a3455b to 2cee3ef Compare July 26, 2018 20:30

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 3 times, most recently from 9fe3318 to c8372d2 Compare July 31, 2018 14:08

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 3 times, most recently from 702c833 to f9df752 Compare August 1, 2018 02:12

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 2 times, most recently from 52dcaba to 0d9e138 Compare August 1, 2018 14:42

juanvallejo added 3 commits August 1, 2018 18:41

update extract command

e5f669d

update rsync

f4ab185

UPSTREAM: 66519: switch attach to use external objs

0f74d82

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from 0d9e138 to e802648 Compare August 1, 2018 22:52

update debug cmd to use externals

c7c536a

juanvallejo force-pushed the jvallejo/more-cmds-externals branch 2 times, most recently from 0adbadb to 8ca712f Compare August 2, 2018 02:18

juanvallejo added 3 commits August 1, 2018 22:48

update secret cmd to externals

54a7df4

update generated completions

302b786

update import restrictions

c20f996

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from 8ca712f to 9095e38 Compare August 2, 2018 02:56

update log cmd to use corev1.PodLogOptions

8a8b443

juanvallejo force-pushed the jvallejo/more-cmds-externals branch from 9095e38 to 8a8b443 Compare August 2, 2018 03:13

soltysh reviewed Aug 2, 2018

View reviewed changes

soltysh mentioned this pull request Aug 2, 2018

Update commands with resource builders to use external versions #20514

Merged

soltysh closed this Aug 2, 2018

stlaz mentioned this pull request Aug 2, 2018

oc adm migrate scc: implement a command for converting SCCs to PSPs #18885

Closed

juanvallejo deleted the jvallejo/more-cmds-externals branch August 2, 2018 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update commands with resource builders to use external versions#20400

Update commands with resource builders to use external versions#20400
juanvallejo wants to merge 8 commits intoopenshift:masterfrom
juanvallejo:jvallejo/more-cmds-externals

juanvallejo commented Jul 23, 2018

Uh oh!

juanvallejo Jul 23, 2018

Uh oh!

soltysh Jul 24, 2018

Uh oh!

juanvallejo Jul 23, 2018

Uh oh!

juanvallejo commented Jul 24, 2018

Uh oh!

juanvallejo Jul 25, 2018

Uh oh!

soltysh Jul 27, 2018

Uh oh!

juanvallejo commented Jul 31, 2018

Uh oh!

openshift-ci-robot commented Aug 1, 2018

Uh oh!

openshift-ci-robot commented Aug 2, 2018

Uh oh!

soltysh Aug 2, 2018

Uh oh!

soltysh commented Aug 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

juanvallejo commented Jul 23, 2018

Uh oh!

juanvallejo Jul 23, 2018

Choose a reason for hiding this comment

Uh oh!

soltysh Jul 24, 2018

Choose a reason for hiding this comment

Uh oh!

juanvallejo Jul 23, 2018

Choose a reason for hiding this comment

Uh oh!

juanvallejo commented Jul 24, 2018

Uh oh!

juanvallejo Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

soltysh Jul 27, 2018

Choose a reason for hiding this comment

Uh oh!

juanvallejo commented Jul 31, 2018

Uh oh!

openshift-ci-robot commented Aug 1, 2018

Uh oh!

openshift-ci-robot commented Aug 2, 2018

Uh oh!

soltysh Aug 2, 2018

Choose a reason for hiding this comment

Uh oh!

soltysh commented Aug 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants