UPSTREAM: 00000: make delete waits match on UID#20305
UPSTREAM: 00000: make delete waits match on UID#20305deads2k merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
approved
| return err | ||
| } | ||
| if status, ok := response.(*metav1.Status); ok && status.Details != nil { | ||
| uidMap[kubectlwait.ResourceLocation{Namespace: info.Namespace, Name: info.Name}] = status.Details.UID |
There was a problem hiding this comment.
does delete never handle multiple resource types? I expected at least group/resource in the key as well
There was a problem hiding this comment.
does delete never handle multiple resource types? I expected at least group/resource in the key as well
oops. Yep.
There was a problem hiding this comment.
does delete never handle multiple resource types? I expected at least group/resource in the key as well
fixed and test updated
| if err != nil { | ||
| return nil, cmdutil.AddSourceToErr("deleting", info.Source, err) | ||
| } | ||
| fmt.Printf("#### %v\n", spew.Sdump(deleteResponse)) |
There was a problem hiding this comment.
drop debug info
fixed
deads2k
force-pushed
the
test-04-delete-fix
branch
2 times, most recently
from
9fbd1d8 to
f3b13c3
Compare
|
upstream here kubernetes/kubernetes#66136 Will rename after green. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
force-pushed
the
test-04-delete-fix
branch
from
f3b13c3 to
7cca473
Compare
|
New changes are detected. LGTM label has been removed. |
|
renamed commit |
|
merging |
|
@deads2k: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_cmd/15509/consoleText indicates that UIDs don't match so the wait never finishes.
@liggitt @soltysh @juanvallejo