Deprecate OPENSHIFT_DEFAULT_REGISTRY environment variable

[mfojtik]

In 3.11 we should drop this variable in favor of master config configuration field that sets this up.

/cc @bparees
/cc @deads2k

Will follow up with deprecation notice in 3.11 release notes.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/cmd/OWNERS [mfojtik]
• pkg/image/OWNERS [mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfojtik]

@dmage @legionus FYI

OpenShift will no longer set this environment variable, but I believe the registry code is already adjusted to pickup this from the registry configuration and does not depend on this variable for at least 1 release.

/cc @sdodson

(to check if there are any usages in ansible)

[deads2k]

I don't see any value to this anymore. Why not just pass the two names around?

[bparees]

this isn't a deprecation, this is a removal....

[bparees]

We need to make sure the online teams are aware of this as i'm pretty sure they've used the env variable because the master-config setting did not appear to be working for them.

[bparees]

In general i'm concerned about the impact on existing clusters where admins may have set the env variable a long time ago and never looked back. How confident are we that those clusters have any, or the same, value in their master-config?

[sdodson]

In 3.9 there's a step to set OPENSHIFT_DEFAULT_REGISTRY env var on the registry DC and the apiserver and controller env vars. Then we set imagePolicyConfig.internalRegistryHostname=docker-registry.default.svc:5000 in the 3.10 install and upgrade. We don't do anything to remove the env vars from the DC or apiserver and controllers in 3.10 upgrade. I think the only thing we'd want to do is remove the environment variables to avoid confusion in 3.11?

[bparees]

I think the only thing we'd want to do is remove the environment variables to avoid confusion in 3.11?

we wouldn't need it on the apiserver+controller, but i think we still want the env var on the registry DC, unless we are injecting it into the registry config as described here: https://docs.openshift.org/latest/install_config/registry/extended_registry_configuration.html#docker-registry-configuration-reference-openshift

also the preferred env var for the registry is now REGISTRY_OPENSHIFT_SERVER_ADDR, as covered here: https://docs.openshift.org/latest/install_config/registry/extended_registry_configuration.html#setting-the-registry-hostname

[openshift-bot]

@mfojtik: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/test cross

[openshift-bot]

/retest

[openshift-merge-robot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-ci-robot]

@mfojtik: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/cross	6570720	link	/test cross
ci/openshift-jenkins/cmd	6570720	link	/test cmd
ci/openshift-jenkins/extended_clusterup	6570720	link	/test extended_clusterup
ci/openshift-jenkins/end_to_end	6570720	link	/test end_to_end
ci/prow/unit	6570720	link	/test unit
ci/prow/cross	6570720	link	/test cross
ci/prow/launch-aws	6570720	link	/test launch-aws
ci/prow/e2e-aws-serial	6570720	link	/test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.