start-build: remove false alarm warning for repo binary input#20100
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jun 29, 2018
Merged
Conversation
4b7cc00 to
def52d8
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Author
|
/retest |
soltysh
approved these changes
Jun 27, 2018
Author
|
/retest flake #20101 |
Author
|
/retest |
Contributor
|
/hold cancel |
Contributor
|
/refresh |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to create a zip archive that was as little as 183 bytes with valid but very short Dockerfile as the only file, so the peek was too large even for an archive created differently than from git repo and should probably not warn a false alarm
ptal @openshift/sig-developer-experience
including the conversation for reference #20090
also, I think the magic number for .gz was not completely correct, it had an extra byte (which is used to signal "deflate" compression algorithm but the byte can have different values as well and still denote .gz archive)
RFC for reference: https://tools.ietf.org/html/rfc1952