Resuse existing imagestreams with new-app

[coreydaley]

https://trello.com/c/BOR33gza/1559-3-reuse-existing-imagestreams-with-new-app-appcreationtechdebt

[coreydaley]

(3) Reuse existing imagestreams with new-app [app_creation][tech_debt]

[coreydaley]

/retest

[coreydaley]

@openshift/sig-developer-experience ptal

[coreydaley]

/retest

[gabemontero]

Curious if the reuse is obvious or at least discernible from the oc new-app output.... suppose the question of whether it should be obvious/discernible is also valid.

@coreydaley - can you provide sample output from the consecutive invocations like in the card description, or duplicating your cmd.sh test from the command line, so we can review that as well?

thanks

[bparees]

Curious if the reuse is obvious or at least discernible from the oc new-app output.... suppose the question of whether it should be obvious/discernible is also valid.

good point @gabemontero. We already reuse imagestreams for output targets (I believe?), so the experience in terms of message output should mirror that.

[coreydaley]

@bparees @gabemontero ptal

Sample command output:

$ oc new-build -D $'FROM node:8\nRUN echo "Test"' --name=node8
--> Found Docker image 6f1597c (8 hours old) from Docker Hub for "node:8"

    * An image stream will be created as "node:8" that will track the source image
    * A Docker build using a predefined Dockerfile will be created
      * The resulting image will be pushed to image stream "node8:latest"
      * Every time "node:8" changes a new build will be triggered

--> Creating resources with label build=node8 ...
    imagestream "node" created
    imagestream "node8" created
    buildconfig "node8" created
--> Success
    Build configuration "node8" created and build triggered.
    Run 'oc logs -f bc/node8' to stream the build progress.

$ oc get is
NAME      DOCKER REPO                       TAGS      UPDATED
node      172.30.1.1:5000/myproject/node    8         5 seconds ago
node8     172.30.1.1:5000/myproject/node8

$ oc new-build -D $'FROM node:10\nRUN echo "Test"' --name=node10
--> Found Docker image 8753ede (8 hours old) from Docker Hub for "node:10"

    * An image stream will be created as "node:10" that will track the source image
    * A Docker build using a predefined Dockerfile will be created
      * The resulting image will be pushed to image stream "node10:latest"
      * Every time "node:10" changes a new build will be triggered

--> Creating resources with label build=node10 ...
    imagestreamtag "node:10" created
    imagestream "node10" created
    buildconfig "node10" created
--> Success
    Build configuration "node10" created and build triggered.
    Run 'oc logs -f bc/node10' to stream the build progress.

$ oc get is
NAME      DOCKER REPO                        TAGS      UPDATED
node      172.30.1.1:5000/myproject/node     10,8      2 seconds ago
node10    172.30.1.1:5000/myproject/node10             
node8     172.30.1.1:5000/myproject/node8

[bparees]

An image stream will be created as "node:10" that will track the source image

let's just change that to always say "imagestream tag" which is more accurate. (even in the first run).

[coreydaley]

@bparees updated in latest push

[bparees]

@coreydaley take off the wip

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/oc/generate/OWNERS [bparees]
• test/cmd/OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment