Skip to content

Add log check to /healthz#19952

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
liggitt:log-healthz
Jun 12, 2018
Merged

Add log check to /healthz#19952
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
liggitt:log-healthz

Conversation

@liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 9, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2018
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Jun 11, 2018

/retest

@liggitt
Copy link
Contributor Author

liggitt commented Jun 11, 2018

/cc @eparis

@eparis
Copy link
Member

eparis commented Jun 11, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 11, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 11, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3611001 into openshift:master Jun 12, 2018
@liggitt liggitt deleted the log-healthz branch June 14, 2018 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sttts sttts Awaiting requested review from sttts

@eparis eparis Awaiting requested review from eparis

Assignees

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liggitt @eparis @openshift-ci-robot @openshift-bot @openshift-merge-robot