UPSTREAM: 64573: remove extra "../" when copying from pod to local#19898
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jun 5, 2018
Merged
Conversation
openshift-ci-robot
added
the
size/S
Contributor
|
The change lgtm, but I'll wait for the upstream to merge. |
Contributor
|
/test unit |
soltysh
approved these changes
Jun 5, 2018
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
Upstream merged
/lgtm
/approve
soltysh
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584555
Copying via
kubectl cpfrom a pod to local will no longer panic if any received tar headers contain an extra "../". This can happen when specifying a remote location beyond "/" - for example:The above command results in a tar header containing an extra "../" in its name (../etc/hosts), causing a panic here.
cc @soltysh