Fix incorrect oc run default option

[michaelgugino]

oc specific 'RunOptions' supplies incorrect default
generator for non-RestartAlways jobs.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1577770

[juanvallejo]

There is no need to change upstream behavior. Just remove the default generator that we are setting in wrappers.go

[michaelgugino]

@juanvallejo NewCmdRunWithOptions does not exist upstream.

[juanvallejo]

@michaelgugino

NewCmdRunWithOptions does not exist upstream.

It still exists in our version of upstream.
Since it looks like we want the PodV1 generator when no generator and restart policy are specified by the user, we could probably default the value of the restart flag in the wrappers file to Never.

cmd.Flag("restart").DefValue = "Never"

cc @soltysh

[michaelgugino]

@juanvallejo As suggested, I made the change only the wrapper and it works as intended.

Looks like restart policy defaults to always by getRestartPolicy; that would result in getting the correct generator (deployment config).

cmd.Flag("restart").DefValue = "Never" would change the default behavior compared to kubectl.

[michaelgugino]

/test gcp

[soltysh]

/approve
I'll let Juan lgtm this

[juanvallejo]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, michaelgugino, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/oc/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.