oc new-app: allow 'dot' in ENV variable names#19688
Conversation
openshift-ci-robot
added
the
size/M
|
looks like this is breaking some existing tests that probably need to be updated: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19688/test_pull_request_origin_cmd/13529/ (the one that is nil-ptr'ing is particularly concerning, that one may need changes in the actual code, not just the test) should also introduce some new tests that will let us know if we regress this support in the future. otherwise lgtm. |
wozniakjan
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
wozniakjan
force-pushed
the
issue8771/oc_new-app/env_var_names_with_dots
branch
8 times, most recently
from
5693a5d to
0d9b36b
Compare
fixes: openshift#8771 reuses validators from kubernetes/kubernetes#48986
wozniakjan
force-pushed
the
issue8771/oc_new-app/env_var_names_with_dots
branch
from
0d9b36b to
d49e16d
Compare
|
/retest |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test unit |
wozniakjan
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
fixes: #8771
reuses validators from kubernetes/kubernetes#48986
ptal @openshift/sig-developer-experience