images: remove duplicate packages#19662
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 18, 2018
Merged
images: remove duplicate packages#19662openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
As a result of openshift#19509, packages `iptables`, `ethtool`, and `socat` ended up being defined twice for `yum install`. This removes duplicate packages in the same command
openshift-ci-robot
added
the
size/XS
wozniakjan
commented
May 9, 2018
| @@ -18,7 +18,7 @@ RUN INSTALL_PKGS=" \ | |||
| socat ethtool device-mapper iptables nmap-ncat e2fsprogs \ | |||
Author
There was a problem hiding this comment.
all three packages, iptables, socat, and ethtool, are three lines higher as well
Contributor
|
/lgtm |
Author
|
@mfojtik do you think it's good for an approval as well? or any comments/requests? |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, mfojtik, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of #19509, packages
iptables,ethtool, andsocatended up being defined twice inyum install. This removes duplicate packages in the same command.It is no issue, only cosmetic change