Correctly handle legacy ungroupified PSP review resources

[enj]

Pluralize SCC Kind for /oapi group map

The Kind name is SecurityContextConstraints, not SecurityContextConstraint.

Signed-off-by: Monis Khan mkhan@redhat.com

---

UPSTREAM: <carry>: Add PSP review to /oapi Resources

This allows oc to correctly create the legacy ungroupified variants of these objects.

Bug 1572562

Signed-off-by: Monis Khan mkhan@redhat.com

---

Add PSP review kinds to /oapi group map

This allows oc to correctly create the legacy ungroupified variants of these objects.

Bug 1572562

Signed-off-by: Monis Khan mkhan@redhat.com

---

/kind bug
/assign @deads2k
@openshift/sig-security @openshift/sig-master
xref #19327

https://bugzilla.redhat.com/show_bug.cgi?id=1572562

[deads2k]

/lgtm

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[enj]

Retagging, rebased on master due to conflict.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/api/OWNERS
• test/cmd/OWNERS [enj]
• test/testdata/OWNERS [enj]
• vendor/k8s.io/kubernetes/staging/src/k8s.io/client-go/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[enj]

/retest

Digest: sha256:f35a14509c3c7c9e757c4fff4ea7682b86eecf6e6b5d9952497b8abac259fbb5
Status: Downloaded newer image for registry.svc.ci.openshift.org/ci/clonerefs:latest
+ break
+ for image in ''\''registry.svc.ci.openshift.org/ci/clonerefs:latest'\''' ''\''registry.svc.ci.openshift.org/ci/initupload:latest'\'''
+ (( i = 0 ))
+ (( i < 5 ))
+ docker pull registry.svc.ci.openshift.org/ci/initupload:latest
Trying to pull repository registry.svc.ci.openshift.org/ci/initupload ... 
latest: Pulling from registry.svc.ci.openshift.org/ci/initupload
6d987f6f4279: Already exists
4cccebe844ee: Already exists
762dc6f69cc5: Pulling fs layer
762dc6f69cc5: Verifying Checksum
762dc6f69cc5: Download complete
762dc6f69cc5: Pull complete
Digest: sha256:6736649f898792ccab7b2a33db5c7b0c05f56bef892c3fc1077e708cdc93f8e5
Status: Downloaded newer image for registry.svc.ci.openshift.org/ci/initupload:latest
+ break
+ clonerefs_args=
+ docker run -e 'JOB_SPEC={"type":"presubmit","job":"test_pull_request_origin_unit","buildid":"12580","refs":{"org":"openshift","repo":"origin","base_ref":"master","base_sha":"0b74dfc55d341566ad1469f99d886eb82545756a","pulls":[{"number":19542,"author":"enj","sha":"6144c4bac363e815c965763ed87090eb8ecf7b87"}]}}' -v /data:/data:z registry.svc.ci.openshift.org/ci/clonerefs:latest --src-root=/data --log=/data/clone.json
time="2018-04-30T19:58:51Z" level=fatal msg="Invalid options: no refs specified to clone" 
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: SYNC REPOSITORIES [00h 00m 33s] ##########
Build step 'Execute shell' marked build as failure

[enj]

/retest