switch reversed old/new objects to validation#19030
switch reversed old/new objects to validation#19030deads2k wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
that's about the only reasonable automated solution I see |
|
/retest |
1 similar comment
|
/retest |
|
ultimately I think there are 3 things we need to fix:
note that item (3) must go in concurrent w/ this PR or else it's going to start getting errors on update. |
|
@miminar i suggest you create a single PR that has all 3 items (and then we're going to need to backport it to 3.9 and 3.7) |
|
ack, on it |
…tion Automatic merge from submit-queue (batch tested with PRs 18905, 18968, 19016, 19037, 19056). Drop image signature annotations Because they were never meant to be allowed. Includes and superseds #19030 (kudos to @deads2k) Closes #19011 Resolves: [rhbz#1557607](https://bugzilla.redhat.com/show_bug.cgi?id=1557607) /assign @bparees @deads2k /cc @mfojtik
|
@deads2k: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-bot
added
the
needs-rebase
6 participants
New objects come first. This means that our update validation never checked to make sure the new image was valid. That means we could have invalid data sitting somewhere. Fun.
@bparees @miminar this is how the annotation from that controller got in there.
@openshift/api-review what shall we do about this one....
/hold
holding while we sort out what to do about the damage.