Skip to content

add some debug to old jenkins plugin tests#18865

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
gabemontero:add-jenkins-ext-tst-dbg
Mar 8, 2018
Merged

add some debug to old jenkins plugin tests#18865
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
gabemontero:add-jenkins-ext-tst-dbg

Conversation

@gabemontero
Copy link
Contributor

@openshift/sig-developer-experience ptal

@openshift-ci-robot openshift-ci-robot added sig/developer-experience size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2018
@bparees
Copy link
Contributor

bparees commented Mar 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

So on the image-eco failure, the jenkins deployment for jenkins_plugins.go failed.

In looking at the pod status, it shows ProgressDeadlineExceeded

In looking at the logs, it is using the image we currently have where we try to do the plugin mgr / update center stuff on startup ... the PR to update jenkins-2-centos:latest, openshift/jenkins#531, is still pending as we try to get the s2i test to pass so we can merge

Also, are template update into master PR #18832 is yet to merge with test flakes

I'll get another test run here while I circle back to those two PRs

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

gabemontero commented Mar 7, 2018

the debug added to this PR helped me with diagnosing the image_ecosysetm failure (in that it allowed me to rule out some possibilities ;-) )

turns out, it looks like the git clone on the s2i strategy frontend build hung, and the other steps did not start ... here is the ouput from dumping the various containers of the build pod:

Mar  7 16:33:14.226: INFO: Running 'oc logs --config=/etc/origin/master/admin.kubeconfig --namespace=extended-test-jenkins-plugin-kznxn-xlcvq pod/frontend-1-build -c git-clone'
Mar  7 16:33:14.543: INFO: Log for pod "frontend-1-build"/"git-clone"
---->
Cloning "https://github.com/openshift/nodejs-ex.git" ...
	Commit:	93fc25fd35068aa311f4722e4d7e5187b06edd7b (Merge pull request #170 from dharmit/add-minishift-to-readme)
	Author:	Ben Parees <bparees@users.noreply.github.com>
	Date:	Tue Mar 6 13:34:31 2018 -0500
<----end of log for "frontend-1-build"/"git-clone"

Mar  7 16:33:14.543: INFO: Running 'oc logs --config=/etc/origin/master/admin.kubeconfig --namespace=extended-test-jenkins-plugin-kznxn-xlcvq pod/frontend-1-build -c manage-dockerfile'
Mar  7 16:33:15.007: INFO: Log for pod "frontend-1-build"/"manage-dockerfile"
---->

<----end of log for "frontend-1-build"/"manage-dockerfile"

Mar  7 16:33:15.007: INFO: Running 'oc logs --config=/etc/origin/master/admin.kubeconfig --namespace=extended-test-jenkins-plugin-kznxn-xlcvq pod/frontend-1-build -c sti-build'
Mar  7 16:33:15.368: INFO: Log for pod "frontend-1-build"/"sti-build"
---->

<----end of log for "frontend-1-build"/"sti-build"

so, I believe this is "environmental"

or, is it another flavor of the tar / stdin stuff, in that git clone is trying to inject data into the build pod ... @bparees - thoughts ?

@bparees
Copy link
Contributor

bparees commented Mar 7, 2018

@gabemontero From what I can see, this is the the tar/stdin closure issue. the git clone container finished(it is not what hung). The container doing the tar injection ("frontend-1-build"/"sti-build"). Because of where it hangs, there's no output yet generated unless you have a higher build loglevel set.

(and there's no output from managedockerfile because it had nothing to do)

@gabemontero
Copy link
Contributor Author

ok cool thanks for the confirmation @bparees

so am I correct in assuming a vendor bump for source-to-image into origin is coming?

@gabemontero
Copy link
Contributor Author

sorry, just saw ... it is #18882

@gabemontero
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18836, 18865, 18466, 18869, 18838).

@openshift-merge-robot openshift-merge-robot merged commit adf344d into openshift:master Mar 8, 2018
@gabemontero gabemontero deleted the add-jenkins-ext-tst-dbg branch March 8, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/developer-experience size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants