Skip to content

UPSTREAM: 58439: fix loading structured admission plugin config#18529

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
liggitt:admission-config
Feb 10, 2018
Merged

UPSTREAM: 58439: fix loading structured admission plugin config#18529
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
liggitt:admission-config

Conversation

@liggitt
Copy link
Contributor

@liggitt liggitt commented Feb 8, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 8, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Feb 8, 2018

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Feb 9, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 9, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 10, 2018

Automatic merge from submit-queue (batch tested with PRs 18529, 18214).

@openshift-merge-robot openshift-merge-robot merged commit 1a8a8e8 into openshift:master Feb 10, 2018
@liggitt liggitt deleted the admission-config branch February 23, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liggitt @sttts @openshift-ci-robot @openshift-bot @openshift-merge-robot