Skip to content

Backport origin pr 18219 limit all#18478

Merged
openshift-merge-robot merged 3 commits intoopenshift:release-3.7from
juanvallejo:backport-origin-pr-18219-limit-all
Feb 9, 2018
Merged

Backport origin pr 18219 limit all#18478
openshift-merge-robot merged 3 commits intoopenshift:release-3.7from
juanvallejo:backport-origin-pr-18219-limit-all

Conversation

@juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Feb 6, 2018

Picks kubernetes/kubernetes#49624
Picks #18219

Depends on #18476

Addresses #18473 (comment)

cc @deads2k

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 6, 2018
@deads2k
Copy link
Contributor

deads2k commented Feb 6, 2018

clean pick?

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Feb 6, 2018

Had to bring in an additional Upstream PR (kubernetes/kubernetes#49624) but other than that, yeah

@deads2k
Copy link
Contributor

deads2k commented Feb 7, 2018

with clean picks

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 7, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Feb 8, 2018

/test gcp

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 9, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 1ce3eee into openshift:release-3.7 Feb 9, 2018
@juanvallejo juanvallejo deleted the backport-origin-pr-18219-limit-all branch February 9, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mrogers950 mrogers950 Awaiting requested review from mrogers950

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juanvallejo @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot