UPSTREAM: 58617: Make ExpandVolumeDevice() idempotent if existing volume capacity meets the requested size#18432
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 5, 2018
Conversation
…ume capacity meets the requested size Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Contributor
Author
|
/assign @gnufied |
Contributor
Author
|
/test gcp |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, jsafrane The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
|
/retest |
Contributor
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Member
|
@humblec did we backport the PR that fixes logic of fetching existing volume from heketi? I think - this PR will not work properly without that other PR right? |
Contributor
|
Automatic merge from submit-queue. |
Contributor
Author
|
@gnufied u mean the annotation PR which correctly fetch the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Humble Chirammal hchiramm@redhat.com