Change Header used for impersonation scopes#18378
Change Header used for impersonation scopes#18378openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
| }) | ||
| } | ||
|
|
||
| const legacyImpersonateUserScopeHeader = "Impersonate-User-Scope" |
There was a problem hiding this comment.
Godoc explaining that older servers respected this. We switched to the new way in 1q 2017.
| @@ -27,16 +30,18 @@ func newImpersonatingRoundTripper(user user.Info, delegate http.RoundTripper) ht | |||
|
|
|||
| func (rt *impersonatingRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) { | |||
There was a problem hiding this comment.
you were going to remove this, right?
|
@deads2k the last force push should be final, PTAL |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest |
|
Flake #12072 |
openshift-merge-robot
added
the
needs-rebase
Note: the upstream function does not forcibliy remove potential existing impersonation headers, and it also uses the existing ones ignoring any new headers we may be setting. This i ok, because we do not depend nor probably want to allow multiple levels of impersonation. Signed-off-by: Simo Sorce <simo@redhat.com>
openshift-merge-robot
removed
lgtm
|
Just rebased |
|
@simo5: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, knobunc, simo5 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Flake #18412 |
|
Flake #18136 |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
5 participants
Fixes #18374