Skip to content

patch controllers for storage#18097

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
deads2k:controller-18-patch-again
Jan 15, 2018
Merged

patch controllers for storage#18097
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
deads2k:controller-18-patch-again

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 12, 2018

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531444

/assign @jsafrane

@jsafrane please confirm this fixes your problem.
@mfojtik

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 12, 2018
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2018
@jsafrane
Copy link
Contributor

jsafrane commented Jan 12, 2018

Tested briefly on GCE, provisioning works.

@jsafrane
Copy link
Contributor

jsafrane commented Jan 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 15, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor

jsafrane commented Jan 15, 2018

/test extended_conformance_install

@jsafrane
Copy link
Contributor

jsafrane commented Jan 15, 2018

/retest

2 similar comments
@0xmichalis
Copy link
Contributor

0xmichalis commented Jan 15, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 15, 2018

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Jan 15, 2018

/lgtm
/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jsafrane, mfojtik

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 15, 2018

Automatic merge from submit-queue (batch tested with PRs 18040, 18097, 18098, 18106, 18087).

@openshift-merge-robot openshift-merge-robot merged commit 302b11f into openshift:master Jan 15, 2018
@deads2k deads2k deleted the controller-18-patch-again branch January 24, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

Assignees

@mfojtik mfojtik

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@deads2k @jsafrane @openshift-bot @0xmichalis @mfojtik @openshift-ci-robot @openshift-merge-robot