fix prometheus readme: bld phase/reason conversion to all lower case …#17809
Conversation
|
I don't remember the history on this. How did we end up with CamelCase for metric names and is that what everyone will use? |
|
Its the value of the metric labels ....we have "phase" and "reason" labels ....originally we were converting values of the build phase and reason fields from the build object (which are camel case) to all lower case, and then in one of PRs that followed the initial delivery of build metrics, during one of the reviews @smarterclayton said to no longer do that conversion. |
|
thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue. |
…was reverted
@openshift/sig-developer-experience