Skip to content

increase the podLogTimeout for downward volume test#17627

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mfojtik:fix-downward-volume-flake
Dec 18, 2017
Merged

increase the podLogTimeout for downward volume test#17627
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mfojtik:fix-downward-volume-flake

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Dec 6, 2017

Increase timeout for the test based on kubernetes/kubernetes#33165

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2017
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 6, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 6, 2017

Based on the linked issue, this depends on the sync-internal, but not sure which one.

@jsafrane @smarterclayton any ideas?

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 6, 2017

/retest

prometheus flake...

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 6, 2017 •
edited
Loading

/retest

flake: #17634

@mfojtik mfojtik force-pushed the fix-downward-volume-flake branch from 80fc753 to ff71daf Compare December 6, 2017 18:18
@mfojtik mfojtik changed the title [WIP] UPSTREAM: 00000: increase the podLogTimeout for downward volume test [WIP] increase the podLogTimeout for downward volume test Dec 6, 2017
@deads2k
Copy link
Contributor

deads2k commented Dec 6, 2017

open this upstream

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 7, 2017

/retest

@deads2k i will, need to make sure this fixes it, will run couple more retests, but so far this PR didn't hit the flake (other PR's are flaking hard on this).

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 7, 2017

@deads2k @jsafrane ok, this seems to fix that flake, I haven't seen it in any test run here.

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 12, 2017

/retest

@mfojtik mfojtik mentioned this pull request Dec 12, 2017
Merged
@mfojtik mfojtik force-pushed the fix-downward-volume-flake branch from ff71daf to f5f8984 Compare December 12, 2017 13:51
@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 12, 2017

@deads2k upstream: kubernetes/kubernetes#57099

I haven't seen this flake here, so this might fix it.

@mfojtik mfojtik changed the title [WIP] increase the podLogTimeout for downward volume test increase the podLogTimeout for downward volume test Dec 12, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2017
@soltysh
Copy link
Contributor

soltysh commented Dec 14, 2017

/retest
/lgtm
/priority queue/fix

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 14, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 14, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 18, 2017

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit a9bfbc4 into openshift:master Dec 18, 2017
@mfojtik mfojtik deleted the fix-downward-volume-flake branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mfojtik @deads2k @soltysh @openshift-ci-robot @openshift-bot @openshift-merge-robot