Skip to content

Automated cherry-pick of #17513 on release-3.7#17620

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.7from
openshift-cherrypick-robot:cherry-pick-17513-to-release-3.7
Jan 11, 2018
Merged

Automated cherry-pick of #17513 on release-3.7#17620
openshift-merge-robot merged 1 commit intoopenshift:release-3.7from
openshift-cherrypick-robot:cherry-pick-17513-to-release-3.7

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 6, 2017

This is an automated cherry-pick of #17513

/assign tnozicka

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2017
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 6, 2017
tnozicka
tnozicka approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tnozicka
Copy link
Contributor

tnozicka commented Dec 6, 2017

/cc @mfojtik

@tnozicka
Copy link
Contributor

tnozicka commented Dec 8, 2017

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Dec 8, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, openshift-cherrypick-robot, tnozicka

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2017
@tnozicka
Copy link
Contributor

tnozicka commented Dec 8, 2017

flake #17684
/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 8, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 9, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor

tnozicka commented Dec 11, 2017

@Kargakis why are merges to release-3.7 blocked on vendor-update? if that's because of rebase such restriction makes sense only for master branch, doesn't it?

@0xmichalis
Copy link
Contributor

0xmichalis commented Dec 11, 2017

Yes, as long as we use the SQ and need to block on vendor-update, you will have to green-button merge PRs in release branches.

@tnozicka
Copy link
Contributor

tnozicka commented Dec 11, 2017

@Kargakis are you saying that SQ can't differentiate the requirements based on target branch or that we just don't do it yet?

@0xmichalis
Copy link
Contributor

0xmichalis commented Dec 11, 2017 •
edited
Loading

are you saying that SQ can't differentiate the requirements based on target branch

Yes, it's hard to do it in the SQ by design. This will be fixed as soon as we switch origin to use tide.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 20, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor

tnozicka commented Dec 21, 2017

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 22, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 23, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 24, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 25, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 27, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 28, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 29, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 30, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 31, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 2, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018 •
edited
Loading

flake: #17924
/test end_to_end

@tnozicka
Copy link
Contributor

tnozicka commented Jan 2, 2018

continuously blocked on #17924

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 3, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 3, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 6, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 7, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 9, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 11, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 387006b into openshift:release-3.7 Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@mfojtik mfojtik Awaiting requested review from mfojtik

1 more reviewer

@tnozicka tnozicka tnozicka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

@tnozicka tnozicka

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @tnozicka @mfojtik @openshift-ci-robot @openshift-bot @0xmichalis @openshift-merge-robot