allow image trigger controller to create custom builds

[jim-minter]

fixes #17074

[jim-minter]

@smarterclayton @bparees making this change appears to resolve #17074 but I want to confirm with you if it's safe to do or not?
#17074 is somewhat of an echo of #14725, which was resolved in #14792; I think maybe this diff was missing from #14792?

@bparees I'm wondering what test coverage is appropriate for this. Also is it worth implementing the event that was suggested in #14725?

[bparees]

@bparees I'm wondering what test coverage is appropriate for this.

we should have an e2e test that verifies ICT triggered builds, it sounds like it needs to test triggering all 4 kinds of builds (s2i, docker, custom, pipeline).

Also is it worth implementing the event that was suggested in #14725?

@jim-minter where would we attach the event? to the buildconfig that we tried to trigger?

[jim-minter]

@jim-minter where would we attach the event? to the buildconfig that we tried to trigger?

That would make sense to me.

[smarterclayton]

/approve

[bparees]

you can drop the prune flake commit, i believe @miminar's fix has merged.

[jim-minter]

/test extended_image_registry

[jim-minter]

@bparees ptal

[bparees]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter, smarterclayton

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• pkg/cmd/OWNERS [bparees,smarterclayton]
• pkg/image/OWNERS [bparees,smarterclayton]
• test/extended/OWNERS [bparees,smarterclayton]
• test/testdata/OWNERS [bparees,smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-merge-robot]

Automatic merge from submit-queue.