Fix up destination MAC of auto-egress-ip packets#17099
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Nov 1, 2017
Merged
Fix up destination MAC of auto-egress-ip packets#17099openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
danwinship
added
component/networking
kind/bug
openshift-ci-robot
added
the
size/S
openshift-merge-robot
added
the
approved
knobunc
approved these changes
Oct 31, 2017
Contributor
knobunc
left a comment
knobunc
left a comment
There was a problem hiding this comment.
Sweet! The change looks good to me. Glad you found the cause!
/lgtm
/approve
Contributor
|
/kind bug |
Contributor
Author
|
/retest |
Contributor
Author
|
oops, it's actually broken |
Also, one final OVS flow fix for egress IPs
danwinship
force-pushed
the
egress-ip-fixes-2
branch
from
7862726 to
286af89
Compare
openshift-merge-robot
removed
the
lgtm
Contributor
Author
|
@knobunc had to tweak it to not try to read the actual tun0 MAC address from unit tests |
Contributor
Author
|
added another fix, for https://bugzilla.redhat.com/show_bug.cgi?id=1507871 |
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
|
/retest |
Contributor
|
/retest Flaked on #17105 |
Contributor
|
/retest Flaked on #17105 |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, eparis, knobunc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto egress packets from pods on nodes other than the one with the egress IP were getting dropped. This turns out to be because the packets will be ignored if you output them on tun0 but they don't have tun0's MAC address as the destination MAC. (For local pods, the default route is via tun0, so the MAC is correct, but for remote pods, the default route is via the tun0 on their node, so the MAC was wrong for the node it eventually ended up on.)
Also includes two other auto-egress-ip OVS flow fixes.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1501876
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1507871