UPSTREAM: 51750: output <none> for colums not found#17023
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 25, 2017
Merged
UPSTREAM: 51750: output <none> for colums not found#17023openshift-merge-robot merged 1 commit intoopenshift:masterfrom
<none> for colums not found#17023openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Member
|
/assign |
Member
|
/lgtm |
Member
|
/kind bug |
Contributor
Author
|
/test extended_conformance_gce |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianofranz, juanvallejo, liggitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Contributor
Author
|
/test extended_conformance_gce |
Contributor
|
Automatic merge from submit-queue (batch tested with PRs 16885, 17023). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505796
Picks changes introduced in kubernetes/kubernetes#51750
to allow the custom-columns to succeed / print all known column values even when
an object's field does not exist.
Before
After
cc @openshift/cli-review