UPSTREAM: 48033: Refactor and simplify generic printer for unknown objects#16892
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Oct 18, 2017
Conversation
openshift-ci-robot
added
the
size/XL
openshift-merge-robot
added
the
vendor-update
openshift-ci-robot
added
size/XXL
Contributor
|
@juanvallejo this looks like a pick of a particular PR in kube. We name those commits |
Contributor
|
Also, was the pick clean? |
juanvallejo
changed the title
juanvallejo
force-pushed
the
jvallejo/bump-humanreadable-printer
branch
2 times, most recently
from
1e973cd to
61a3ec0
Compare
Contributor
|
Clean pick, merged upstream in 1.8. I'll leave the judgement about in or out of 3.7 to someone closer to the bug. @fabianofranz /approve |
openshift-merge-robot
added
the
approved
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, fabianofranz, juanvallejo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
Author
|
/test extended_conformance_install_update |
1 similar comment
Contributor
Author
|
/test extended_conformance_install_update |
Contributor
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds default table handler to the humanreadableprinter.
Fixes printer output for resources without a printHandler.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1455115
cc @openshift/cli-review @smarterclayton @deads2k