Skip to content

UPSTREAM: 53857: kubelet sync pod throws more detailed events#16865

Merged
openshift-merge-robot merged 6 commits intoopenshift:masterfrom
joelsmith:node-events
Oct 17, 2017
Merged

UPSTREAM: 53857: kubelet sync pod throws more detailed events#16865
openshift-merge-robot merged 6 commits intoopenshift:masterfrom
joelsmith:node-events

Conversation

@joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Oct 13, 2017

Also includes the following upstream dependant PRs:

UPSTREAM: 50350: Wait for container cleanup before deletion
UPSTREAM: 48970: Recreate pod sandbox when the sandbox does not have an IP address.
UPSTREAM: 48589: When faild create pod sandbox record event.
UPSTREAM: 48584: Move event type
UPSTREAM: 47599: Rerun init containers when the pod needs to be restarted

xrefs:
kubernetes/kubernetes#53857
kubernetes/kubernetes#50350
kubernetes/kubernetes#48970
kubernetes/kubernetes#48589
kubernetes/kubernetes#48584
kubernetes/kubernetes#47599

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2017
@joelsmith joelsmith added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2017
@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 13, 2017

Marked do-not-merge/work-in-progress since the upstream PR isn't merged and is similarly marked. I'll track that PR and update this one as necessary with any code updates.

cc @derekwaynecarr

@deads2k
Copy link
Contributor

deads2k commented Oct 13, 2017

/unassign
/assign sjenning

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 13, 2017

If we take 50350, we need to take the follow-on as well.

kubernetes/kubernetes#53233

@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 13, 2017

/retest

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 13, 2017

/kind bug

Will merge on green

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 13, 2017
@joelsmith joelsmith removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2017
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 13, 2017

/test extended_conformance_install_update

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 14, 2017

/retest

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 14, 2017
@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 15, 2017

/retest
Looks like the broken test extended_conformance_install_update
is happy again.

@joelsmith joelsmith closed this Oct 15, 2017
@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 15, 2017

Closed by mistake (fat fingered on my phone)
/retest

@joelsmith joelsmith reopened this Oct 15, 2017
@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 16, 2017

/retest

@sjenning
Copy link
Contributor

sjenning commented Oct 16, 2017

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16865/origin-ci-verify-origin/215/

Saying you need to run hack/update-generated-swagger-spec.sh. Suggest rebasing and running that.

Could also be this though:
#16720

@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 16, 2017

@sjenning While that test shows up as red on the dashboard, it's not the one that's keeping this PR out of the merge queue. That's https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16865/test_pull_request_origin_extended_conformance_gce/9734/ which has a baffling error that I can't reproduce on my own system.

I tried rebasing and updating the swagger API, but it ended up being a no-op.

@sjenning
Copy link
Contributor

sjenning commented Oct 16, 2017

So out of the last 4 test runs:

Failed 3 times, passed on latest run:
Service Catalog [localhost] ansible_service_broker : validate Dockerhub registry settings

Failed on the latest run but not before:
[Feature:DeploymentConfig] deploymentconfigs with enhanced status [Conformance] should include various info in status [Suite:openshift/conformance/parallel]

Let's roll the dice again.

/retest

@sjenning
Copy link
Contributor

sjenning commented Oct 16, 2017

might be related to closed flake #13644 ?

@joelsmith
Copy link
Contributor Author

joelsmith commented Oct 16, 2017

@derekwaynecarr it's passing the tests now

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 17, 2017

/approve no-issue
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 17, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, joelsmith

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@joelsmith joelsmith mentioned this pull request Oct 17, 2017
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 17, 2017

Automatic merge from submit-queue (batch tested with PRs 16889, 16865).

@openshift-merge-robot openshift-merge-robot merged commit 84e0585 into openshift:master Oct 17, 2017
@joelsmith joelsmith deleted the node-events branch October 17, 2017 18:48
@derekwaynecarr derekwaynecarr mentioned this pull request Oct 17, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Oct 17, 2017
@openshift-merge-robot
Merge pull request #16907 from joelsmith/node-events-stage
bc2db51 
Automatic merge from submit-queue.

UPSTREAM: 53857: kubelet sync pod throws more detailed events

See the version of this PR against the master branch for more information:
#16865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sjenning sjenning

@soltysh soltysh

@derekwaynecarr derekwaynecarr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joelsmith @deads2k @derekwaynecarr @sjenning @openshift-merge-robot @soltysh @openshift-ci-robot