1.7.7, 1.7.8 Cherry picks by soltysh · Pull Request #16722 · openshift/origin

soltysh · 2017-10-06T14:28:08Z

Fixes #16361

soltysh · 2017-10-06T14:56:33Z

@ironcladlou fyi

soltysh · 2017-10-06T18:25:57Z

/retest

liggitt · 2017-10-07T04:54:07Z

picks look fine, tests need looking into.

unit test is legitimate:

In suite "github.com/openshift/origin/pkg/cmd/server/bootstrappolicy", test case "TestGetBootstrapNamespaceRoleBindings" failed:
=== RUN   TestGetBootstrapNamespaceRoleBindings
--- FAIL: TestGetBootstrapNamespaceRoleBindings (0.02s)
	policy_test.go:124: Bootstrap policy data does not match the test fixture in ../../../../test/testdata/bootstrappolicy/bootstrap_namespace_role_bindings.yaml
	policy_test.go:135: Diff between bootstrap data and fixture data in ../../../../test/testdata/bootstrappolicy/bootstrap_namespace_role_bindings.yaml:

couln't actually spot the failed integration test

They are alpha and were sunset and replaced by CRD.

…ttable when empty and updates the StatefulSet controller to set them when empty

…dbalancer healthcheck is nil

liggitt · 2017-10-09T20:25:39Z

/lgtm

openshift-merge-robot · 2017-10-09T20:25:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [liggitt]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-bot · 2017-10-10T05:45:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

soltysh · 2017-10-10T10:20:32Z

Added missing import, I'll apply the labels back when tests will be green.

soltysh · 2017-10-10T11:20:55Z

flake #16716

soltysh · 2017-10-10T11:22:41Z

/retest

soltysh · 2017-10-10T15:49:03Z

pkg/build/registry/buildconfig/webhook.go

 // ProcessWebHook does the actual work of processing the webhook request
 func (w *WebHookHandler) ProcessWebHook(writer http.ResponseWriter, req *http.Request, ctx apirequest.Context, name, subpath string) error {
-	parts := strings.Split(subpath, "/")
+	parts := strings.Split(strings.TrimPrefix(subpath, "/"), "/")


@bparees fyi

@soltysh thanks.... k8s changed something about how the provide the request path to us??

Subresource path was stripping leading/trailing slashes incorrectly. Fixed in 1.7.8

Yup, just that.

openshift-ci-robot · 2017-10-10T17:25:20Z

@soltysh: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/experimental/integration	`da5f663`	link	`/test origin-it`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh · 2017-10-10T18:53:43Z

/retest

soltysh · 2017-10-11T13:18:10Z

Applying the lgtm label on green tests.

openshift-merge-robot · 2017-10-11T16:08:28Z

Automatic merge from submit-queue (batch tested with PRs 16600, 16722, 16760, 16784).

soltysh assigned liggitt Oct 6, 2017

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2017

soltysh added the kind/bug Categorizes issue or PR as related to a bug. label Oct 6, 2017

liggitt changed the title ~~1.7.X Cherry picks~~ 1.7.7, 1.7.8 Cherry picks Oct 7, 2017

soltysh added 2 commits October 9, 2017 18:44

UPSTREAM: 52823: Third party resources should not be part of conformance

c20a371

They are alpha and were sunset and replaced by CRD.

UPSTREAM: 51199: Makes Hostname and Subdomain fields of v1.PodSpec se…

993e6f3

…ttable when empty and updates the StatefulSet controller to set them when empty

soltysh force-pushed the cherry-picks branch from b3f300f to 20945e8 Compare October 9, 2017 18:16

soltysh added 5 commits October 9, 2017 22:01

UPSTREAM: 52602: etcd3 store: retry w/live object on conflict

379148d

UPSTREAM: 52545: use specified discovery information if possible

9b006c4

UPSTREAM: 52775: Fix panic in ControllerManager when GCE external loa…

7a029c0

…dbalancer healthcheck is nil

UPSTREAM: 52947: Preserve leading and trailing slashes on proxy subpaths

9fdb4ed

UPSTREAM: 53299: Correct APIGroup for RoleBindingBuilder Subjects

9f20f52

soltysh force-pushed the cherry-picks branch from 20945e8 to 7f237a5 Compare October 9, 2017 20:01

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2017

liggitt mentioned this pull request Oct 10, 2017

UPSTREAM: 46542: Ignore pods for quota marked for deletion whose node is unreachable #16425

Closed

soltysh added 3 commits October 10, 2017 12:19

UPSTREAM: 52604: Use separate client for node status loop

88592ac

UPSTREAM: 53332: Ignore pods for quota that exceed deletion grace period

714d511

UPSTREAM: 53457: Ignore notFound when deleting firewall

5d4c7f1

soltysh force-pushed the cherry-picks branch from 7f237a5 to da5f663 Compare October 10, 2017 10:20

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2017

Origin changes after cherry-picks

c1f8eef

soltysh force-pushed the cherry-picks branch from da5f663 to c1f8eef Compare October 10, 2017 15:48

soltysh commented Oct 10, 2017

View reviewed changes

soltysh added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2017

openshift-merge-robot merged commit 498cba9 into openshift:master Oct 11, 2017

soltysh deleted the cherry-picks branch October 12, 2017 08:41

Conversation

soltysh commented Oct 6, 2017

Uh oh!

soltysh commented Oct 6, 2017

Uh oh!

soltysh commented Oct 6, 2017

Uh oh!

liggitt commented Oct 7, 2017

Uh oh!

liggitt commented Oct 9, 2017

Uh oh!

openshift-merge-robot commented Oct 9, 2017

Uh oh!

openshift-bot commented Oct 10, 2017

Uh oh!

soltysh commented Oct 10, 2017

Uh oh!

soltysh commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soltysh commented Oct 10, 2017

Uh oh!

soltysh Oct 10, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Oct 10, 2017

Choose a reason for hiding this comment

Uh oh!

liggitt Oct 10, 2017

Choose a reason for hiding this comment

Uh oh!

soltysh Oct 10, 2017

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soltysh commented Oct 10, 2017

Uh oh!

soltysh commented Oct 11, 2017

Uh oh!

openshift-merge-robot commented Oct 11, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

soltysh commented Oct 10, 2017 •

edited

Loading

openshift-ci-robot commented Oct 10, 2017 •

edited

Loading