allow template labels to be parameterised

[jim-minter]

fixes #16223

docs: openshift/openshift-docs#5401

[jim-minter]

@bparees it just occurred to me, as this stands, this will allow label /values/ to be parameterised, but not label keys (or ${{json}}) - do you think either of these is warranted?

[bparees]

@bparees it just occurred to me, as this stands, this will allow label /values/ to be parameterised, but not label keys (or ${{json}}) - do you think either of these is warranted?

allowing label keys to be parameterized is warranted imho. Supporting ${{}} syntax is not needed since label keys+values can only be strings anyway(right?)

[jim-minter]

/retest

[jim-minter]

/retest

[bparees]

this will need a docs follow up too.

[jim-minter]

@bparees docs updated

[bparees]

lgtm but holding for 3.8 since we are past feature cut on 3.7.

[bparees]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• pkg/template/OWNERS [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[bparees]

/retest

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-ci-robot]

@jim-minter: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	6fd1097	link	/test extended_conformance_install_update
ci/openshift-jenkins/cmd	6fd1097	link	/test cmd
ci/openshift-jenkins/extended_conformance_gce	6fd1097	link	/test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install	6fd1097	link	/test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 16605, 17270).