Decrement retries count during migration#16340
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 14, 2017
Merged
Decrement retries count during migration#16340openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
This change fixes a bug in the migration command that could lead to it being permanently stuck in a retry loop. This would only happen if some other entity continuously changed a resource that was in the process of being migrated. The command would then attempt to retry due to the conflict error. Since the retry count was never decremented, the migration would essentially be stuck in an infinite loop. To avoid having to mutate global state, retries was removed as a field of migrateTracker. It is instead directly passed to the try function and thus is reset on every invocation of result.Visit. Signed-off-by: Monis Khan <mkhan@redhat.com>
openshift-ci-robot
added
the
size/S
Contributor
Author
|
/retest docker.io flake: |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, smarterclayton The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
Contributor
|
Automatic merge from submit-queue (batch tested with PRs 16339, 16340) |
jupierce
added a commit
that referenced
this pull request
Sep 14, 2017
…stream-stage Automated cherry pick of #16340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the migration command that could lead to it being permanently stuck in a retry loop. This would only happen if some other entity continuously changed a resource that was in the process of being migrated. The command would then attempt to retry due to the conflict error. Since the retry count was never decremented, the migration would essentially be stuck in an infinite loop. To avoid having to mutate global state,
retrieswas removed as a field ofmigrateTracker. It is instead directly passed to thetryfunction and thus is reset on every invocation ofresult.Visit.Signed-off-by: Monis Khan mkhan@redhat.com
/assign @smarterclayton
@sdodson @jupierce you saw this during an upgrade: https://bugzilla.redhat.com/show_bug.cgi?id=1489168