deprecate the imagestream.spec.DockerImageRepository field by bparees · Pull Request #16181 · openshift/origin

bparees · 2017-09-06T18:21:55Z

No description provided.

bparees · 2017-09-06T18:22:12Z

jim-minter · 2017-09-06T22:43:50Z

@bparees hack/update-generated-swagger-descriptions.sh needed

jim-minter · 2017-09-06T22:47:41Z

pkg/image/apis/image/v1/types.go

 	// Annotations associated with images using this tag
 	Annotations map[string]string `json:"annotations" protobuf:"bytes,2,rep,name=annotations"`
-	// From is a reference to an image stream tag or image stream this tag should track
+	// Optional; if specified, a reference to another image that this tag should point to. Valid values


Question - should the docstrings for other fields match ../types.go too?

probably, will update.

bparees · 2017-09-07T02:07:36Z

@jim-minter fixed
@openshift/api-review ptal

smarterclayton · 2017-09-07T02:18:08Z

pkg/image/apis/image/v1/types.go

 	// lookupPolicy controls how other resources reference images within this namespace.
 	LookupPolicy ImageLookupPolicy `json:"lookupPolicy,omitempty" protobuf:"bytes,3,opt,name=lookupPolicy"`
 	// dockerImageRepository is optional, if specified this stream is backed by a Docker repository on this server
+	// Deprecated: This field is deprecated as of v3.7 and will be removed in a future release


Needs a period after this sentence.

bparees · 2017-09-07T04:11:28Z

/retest Ben Parees | OpenShift

…

On Sep 6, 2017 23:33, "OpenShift CI Robot" ***@***.***> wrote: @bparees <https://github.com/bparees>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/extended_builds 34dc649 <34dc649> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_extended_builds/195/> /test extended_builds ci/openshift-jenkins/verify 745e72b <745e72b> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_verify/2184/> /test verify Full PR test history <https://openshift-gce-devel.appspot.com/pr/16181>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://github.com/kubernetes/test-infra/blob/master/commands.md>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16181 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3oKOj4UireS7ulERkkFzCuE5saEGks5sf2QdgaJpZM4POx3T> .

smarterclayton · 2017-09-07T04:13:49Z

/approve On Thu, Sep 7, 2017 at 12:11 AM, Ben Parees <notifications@github.com> wrote:

…

/retest Ben Parees | OpenShift On Sep 6, 2017 23:33, "OpenShift CI Robot" ***@***.***> wrote: > @bparees <https://github.com/bparees>: The following tests *failed*, say > /retest to rerun them all: > Test name Commit Details Rerun command > ci/openshift-jenkins/extended_builds 34dc649 > <https://github.com/openshift/origin/commit/ 34dc649> > link > <https://openshift-gce-devel.appspot.com/build/origin-ci- test/pr-logs/pull/16181/test_pull_request_origin_extended_builds/195/> /test > extended_builds > ci/openshift-jenkins/verify 745e72b > <https://github.com/openshift/origin/commit/ 745e72b> > link > <https://openshift-gce-devel.appspot.com/build/origin-ci- test/pr-logs/pull/16181/test_pull_request_origin_verify/2184/> /test > verify > > Full PR test history <https://openshift-gce-devel.appspot.com/pr/16181>. Your > PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please > help us cut down on flakes by linking to > <https://github.com/kubernetes/community/blob/master/contributors/devel/ flaky-tests.md#filing-issues-for-flaky-tests> > an open issue > <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you > hit one in your PR. > > Instructions for interacting with me using PR comments are available here > <https://github.com/kubernetes/community/blob/master/contributors/devel/ pull-requests.md>. > If you have questions or suggestions related to my behavior, please file an > issue against the kubernetes/test-infra > <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue :> > repository. I understand the commands that are listed here > <https://github.com/kubernetes/test-infra/blob/master/commands.md>. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#16181 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ AEvl3oKOj4UireS7ulERkkFzCuE5saEGks5sf2QdgaJpZM4POx3T> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16181 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pw4xWc0gr4qz-Q1FswMIaa5NCx7Qks5sf2zzgaJpZM4POx3T> .

bparees · 2017-09-07T13:08:29Z

bparees · 2017-09-07T13:41:38Z

/retest Ben Parees | OpenShift

…

On Sep 7, 2017 9:31 AM, "OpenShift CI Robot" ***@***.***> wrote: @bparees <https://github.com/bparees>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/extended_builds 34dc649 <34dc649> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_extended_builds/195/> /test extended_builds ci/openshift-jenkins/extended_conformance_gce 745e72b <745e72b> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_extended_conformance_gce/7407/> /test extended_conformance_gce ci/openshift-jenkins/verify 745e72b <745e72b> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_verify/2201/> /test verify Full PR test history <https://openshift-gce-devel.appspot.com/pr/16181>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://github.com/kubernetes/test-infra/blob/master/commands.md>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16181 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3tpVN8lKqU5MM0-eMMzDbORWRFVBks5sf_AcgaJpZM4POx3T> .

bparees · 2017-09-07T13:56:54Z

going to assume @smarterclayton's /approve qualifies as a
/lgtm

and api-approval.

openshift-ci-robot · 2017-09-07T13:56:55Z

@bparees: you cannot LGTM your own PR.

Details

In response to this:

going to assume @smarterclayton's /approve qualifies as a
/lgtm

and api-approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2017-09-07T16:32:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

smarterclayton · 2017-09-07T19:25:32Z

/approve for api

…

On Thu, Sep 7, 2017 at 12:56 PM, OpenShift CI Robot < ***@***.***> wrote: @bparees <https://github.com/bparees>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/extended_builds 34dc649 <34dc649> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_extended_builds/195/> /test extended_builds ci/openshift-jenkins/verify 745e72b <745e72b> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16181/test_pull_request_origin_verify/2226/> /test verify Full PR test history <https://openshift-gce-devel.appspot.com/pr/16181>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://github.com/kubernetes/test-infra/blob/master/commands.md>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16181 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p06hDmuCouWxLrB_vSDT9tyL1RVDks5sgCBOgaJpZM4POx3T> .

openshift-merge-robot · 2017-09-07T19:25:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, smarterclayton

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bparees,smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-bot · 2017-09-07T22:35:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2017-09-08T02:37:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2017-09-08T03:02:09Z

@bparees: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_builds	`34dc649`	link	`/test extended_builds`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2017-09-08T08:43:06Z

Automatic merge from submit-queue

openshift-merge-robot assigned smarterclayton and jim-minter Sep 6, 2017

openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-api-review labels Sep 6, 2017

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2017

jim-minter reviewed Sep 6, 2017

View reviewed changes

bparees force-pushed the fix_tags branch from 52d21dc to 7e58a2c Compare September 7, 2017 01:40

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2017

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2017

bparees force-pushed the fix_tags branch from 7e58a2c to 34dc649 Compare September 7, 2017 01:45

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2017

bparees force-pushed the fix_tags branch from 34dc649 to d83d592 Compare September 7, 2017 02:06

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2017

bparees force-pushed the fix_tags branch from d83d592 to 869bceb Compare September 7, 2017 02:07

smarterclayton reviewed Sep 7, 2017

View reviewed changes

bparees force-pushed the fix_tags branch from 869bceb to 745e72b Compare September 7, 2017 03:09

bparees added api-approved and removed needs-api-review labels Sep 7, 2017

openshift-merge-robot added the needs-api-review label Sep 7, 2017

bparees added lgtm Indicates that a PR is ready to be merged. and removed needs-api-review labels Sep 7, 2017

openshift-merge-robot added the needs-api-review label Sep 7, 2017

deprecate imagestream dockerImageRepository field

856dfa1

bparees force-pushed the fix_tags branch from 745e72b to 856dfa1 Compare September 8, 2017 04:48

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2017

bparees added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2017

openshift-merge-robot merged commit 3265c5c into openshift:master Sep 8, 2017

bparees deleted the fix_tags branch September 15, 2017 01:27

Conversation

bparees commented Sep 6, 2017

Uh oh!

bparees commented Sep 6, 2017

Uh oh!

jim-minter commented Sep 6, 2017

Uh oh!

jim-minter Sep 6, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

bparees commented Sep 7, 2017

Uh oh!

smarterclayton Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

bparees commented Sep 7, 2017 via email

Uh oh!

smarterclayton commented Sep 7, 2017 via email

Uh oh!

bparees commented Sep 7, 2017 via email

Uh oh!

bparees commented Sep 7, 2017 via email

Uh oh!

bparees commented Sep 7, 2017

Uh oh!

openshift-ci-robot commented Sep 7, 2017

Uh oh!

openshift-bot commented Sep 7, 2017

Uh oh!

smarterclayton commented Sep 7, 2017 via email

Uh oh!

openshift-merge-robot commented Sep 7, 2017

Uh oh!

openshift-bot commented Sep 7, 2017

Uh oh!

openshift-bot commented Sep 8, 2017

Uh oh!

openshift-ci-robot commented Sep 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-robot commented Sep 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Sep 8, 2017 •

edited

Loading