UPSTREAM: 49142: Slow-start batch pod creation of rs, rc, ds, jobs#16111
UPSTREAM: 49142: Slow-start batch pod creation of rs, rc, ds, jobs#16111openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
This looks fairly invasive. Is it a regression from 3.6? Did it get picked into 1.7? Is there an issue or bug corresponding to the pick? |
|
@deads2k sorry, I forgot to edit the PR comments with the xref to upstream. Also, I'm happy to have you review if you like, but @derekwaynecarr reviewed upstream so it might be easier to have him also review this pick PR. I'll go update the PR comment now with xref details. |
My concern is more about impacts to being able to pick future maintenance into 3.7. Having a description of the problem is important to judging the tradeoff. Thanks for the links. |
|
/test extended_conformance_gce |
|
The upstream PR has merged and will be in 1.8. @derekwaynecarr is this ready for a review? |
|
@deads2k -- this protects against the following: kubernetes/kubernetes#49145 |
|
/assign @derekwaynecarr |
|
@joelddiaz - i would like the upstream fix to soak a few days before merging this. |
|
wrong joel, @joelsmith -- i want to let this soak for a few days upstream before merging. |
|
Thanks, sounds good. |
|
@derekwaynecarr kubernetes/kubernetes#49142 has been in upstream 10 days now. How long did we want this to soak? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, joelsmith The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
integration test is currently broken #16323 |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 16295, 16314, 16326, 16111) |
xref kubernetes/kubernetes#49142
upstream issue: kubernetes/kubernetes#49145