WIP: use generated clientset for deployment controllers and add expansion for instantiate#15981
WIP: use generated clientset for deployment controllers and add expansion for instantiate#15981mfojtik wants to merge 2 commits intoopenshift:masterfrom
Conversation
openshift-merge-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
mfojtik
force-pushed
the
deploy-clientset
branch
from
c403105 to
4911374
Compare
|
@deads2k @smarterclayton PTAL I tested this and it seems like we can add missing methods via expansion. (i need to plumb tests && stuff but want to get agreement that expansions is the right way to do this... ) |
mfojtik
force-pushed
the
deploy-clientset
branch
from
4911374 to
5012efa
Compare
mfojtik
force-pushed
the
deploy-clientset
branch
from
5012efa to
099f5ee
Compare
openshift-merge-robot
added
size/L
enj
left a comment
enj
left a comment
There was a problem hiding this comment.
Seems reasonable but I am not familiar enough with the generated code to lgtm.
| @@ -1,3 +1 @@ | |||
| package internalversion | |||
There was a problem hiding this comment.
no, clientgen will recreate it :-) without interface...
|
@mfojtik: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mfojtik PR needs rebase |
openshift-merge-robot
added
the
needs-rebase
|
closing this in favor of #16019 |
5 participants
No description provided.