Skip to content

UPSTREAM: 49724: skip WaitForAttachAndMount for terminated pods in syncPod#15534

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.6from
sjenning:pick-49724-3.6
Aug 27, 2017
Merged

UPSTREAM: 49724: skip WaitForAttachAndMount for terminated pods in syncPod#15534
openshift-merge-robot merged 1 commit intoopenshift:release-3.6from
sjenning:pick-49724-3.6

Conversation

@sjenning
Copy link
Contributor

@sjenning sjenning commented Jul 28, 2017

master PR #15533

This can wait for 3.6.1

@derekwaynecarr

@openshift-merge-robot openshift-merge-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
@smarterclayton smarterclayton modified the milestone: 3.6.x Jul 28, 2017
@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 1, 2017

/test end_to_end

@sjenning
Copy link
Contributor Author

sjenning commented Aug 2, 2017

@stevekuznetsov I hit

+ hack/env make build-router-e2e-test
[INFO] Pulling the openshift/origin-release:golang-1.7 image to update it...
Trying to pull repository registry.access.redhat.com/openshift/origin-release ... 
Trying to pull repository docker.io/openshift/origin-release ... 
golang-1.7: Pulling from docker.io/openshift/origin-release
Digest: sha256:9dbd5afabca198001e9cae62eaca8646248770fe5a9e10f67baab034ab44309b
make: *** No rule to make target `build-router-e2e-test'.  Stop.

Doesn't seem like that would be a flake but I'll do a retest in case it was or has been fixed in the meantime.

/test end_to_end

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 2, 2017 •
edited
Loading

Ah, crap. This branch needs get the changes backported @deads2k

@sjenning
Copy link
Contributor Author

sjenning commented Aug 23, 2017

/retest

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Aug 23, 2017

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 23, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 24, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@sjenning
Copy link
Contributor Author

sjenning commented Aug 24, 2017

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor Author

sjenning commented Aug 24, 2017

flake #15941

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 25, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 25, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 27, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 27, 2017

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 50ec04d into openshift:release-3.6 Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@derekwaynecarr derekwaynecarr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v3.6

Development

Successfully merging this pull request may close these issues.

7 participants

@sjenning @stevekuznetsov @derekwaynecarr @openshift-merge-robot @openshift-bot @smarterclayton @openshift-ci-robot