print typed podlist for correct serialization#15519
Merged
jupierce merged 1 commit intoopenshift:release-3.6from Aug 1, 2017
Merged
print typed podlist for correct serialization#15519jupierce merged 1 commit intoopenshift:release-3.6from
jupierce merged 1 commit intoopenshift:release-3.6from
Conversation
Contributor
|
/lgtm |
Contributor
|
Contributor
|
/test extended_conformance_install_update |
Contributor
|
So this missed getting in for 3.6 because of a missing gofmt run on the changed code? |
Contributor
|
yes, and is still needed |
473623d to
44842cd
Compare
Contributor
Author
|
@liggitt wondering if you could tag once more, thanks |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, liggitt Associated issue requirement bypassed by: liggitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Member
|
Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1473455
Backporting #15411
cc @deads2k @fabianofranz