Add gRPC client side metrics to apiservers#15517
Add gRPC client side metrics to apiservers#15517smarterclayton merged 3 commits intoopenshift:release-3.6from
Conversation
We cannot access grpc inside the etcd tree, so we can't set dial options normally. We probably want to converge on a gRPC version that matches etcd rather than kubernetes for our server packages eventually.
Also has to be a carry because of the vendoring of etcd's gRPC and Kube won't carry patches.
openshift-merge-robot
added
the
size/S
|
etcd3 has no default ootb metrics from kube, which is non-optimal. This gives us some visibility for now, we can improve in 3.7 (I'm going to wrap the etcd3 storage engine the same way as etcd2) |
|
@deads2k hold your nose |
|
/approve no-issue |
openshift-merge-robot
added
the
approved
|
/retest |
|
Actually let me make this a <drop> |
|
wow, go makes things difficult. open issue upstream for making this better? |
|
I don't really know what those dial options do... is there any chance we'd need to switch that off? |
|
No, they just add interceptors that add GRPC metrics. Tiny risk, but none I can think of. |
|
/lgtm then |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, smarterclayton Associated issue requirement bypassed by: smarterclayton The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
DaemonSet flake |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, smarterclayton Associated issue requirement bypassed by: smarterclayton The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
5 participants
Better than nothing, even though this requires carries due to the vendoring of grpc under etcd.