Skip to content

Unconditionally remove proxy headers to prevent httpoxy#15146

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
simo5:httpoxy
Jul 14, 2017
Merged

Unconditionally remove proxy headers to prevent httpoxy#15146
openshift-bot merged 1 commit intoopenshift:masterfrom
simo5:httpoxy

Conversation

@simo5
Copy link
Contributor

@simo5 simo5 commented Jul 11, 2017

See https://httpoxy.org/ for more details.
Fixes #14516

{{- end }}


# Strip off Proxy headers to prevent HTTTpoxy (https://httpoxy.org/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTTpoxy -> HTTPoxy

@enj
Copy link
Contributor

enj commented Jul 11, 2017

@openshift/networking

See https://httpoxy.org/ for more details.

Signed-off-by: Simo Sorce <simo@redhat.com>
Copy link
Contributor

@pecameron pecameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5
Copy link
Contributor Author

simo5 commented Jul 14, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c75a93b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3143/) (Base Commit: 6ba4bf5) (PR Branch Commit: c75a93b)

@knobunc
Copy link
Contributor

knobunc commented Jul 14, 2017

Ok, let's [merge] this now and we can decide if we need to add control of removing arbitrary headers in the future.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3143/) (Base Commit: 6ba4bf5) (PR Branch Commit: c75a93b) (Image: devenv-rhel7_6443)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c75a93b

@openshift-bot openshift-bot merged commit 245158d into openshift:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants