UPSTREAM: 48763: Add Local and Unstructured resource builder attributes and handle <rsrsc> / <name> pairs when --local is set by juanvallejo · Pull Request #15140 · openshift/origin

juanvallejo · 2017-07-11T15:41:48Z

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1390139

Adds an error message if a / pair is specified in an oc set ... sub command with a --local flag.

# oc set image dc/idling-echo idling-tcp-echo=ruby:2.0 --local -o yaml
error: you must specify resources by --filename when --local is set.
Example resource specifications include:
   '-f rsrc.yaml'
   '--filename=rsrc.json'

cc @openshift/cli-review

juanvallejo · 2017-07-11T15:42:29Z

[test]

openshift-bot · 2017-07-11T15:47:23Z

Evaluated for origin test up to a932a1f

openshift-bot · 2017-07-11T17:39:22Z

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3046/) (Base Commit: 6c5dafb) (PR Branch Commit: a932a1f)

juanvallejo · 2017-07-11T18:10:40Z

cc @liggitt

openshift-merge-robot · 2017-07-25T19:04:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: mfojtik

Assign the PR to them by writing /assign @mfojtik in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-07-28T22:11:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: mfojtik

Assign the PR to them by writing /assign @mfojtik in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

juanvallejo · 2017-10-27T13:51:52Z

/retest

juanvallejo · 2017-10-30T17:32:15Z

/kind bug

…--local

Moves DisabledClientMapperForMapping wrapper to new Local attribute. Removes Factory#NewUnstructuredBuilder in favor of new Unstructured builder attribute.

…d builder attrs

juanvallejo · 2017-12-04T21:02:48Z

/retest

juanvallejo · 2017-12-04T23:36:47Z

/test extended_conformance_gce

juanvallejo · 2017-12-05T15:38:26Z

/test extended_conformance_gce

fabianofranz · 2017-12-06T20:46:40Z

@deads2k can you PTAL if this hits the new rebase too hard? The upstream commits are there for some time already.

juanvallejo · 2017-12-06T22:59:21Z

Closing as the current rebase appears to be bringing these commits in: 2b1e0d4#diff-2c0180e8c8452be63baa6d1c6877dc8eR225

juanvallejo changed the title ~~add error message if <rsrc>/<name> pairs are specified w/ --local flag~~ UPSTREAM: 48763: add error message if <rsrc>/<name> pairs are specified w/ --local flag Jul 11, 2017

juanvallejo requested review from fabianofranz and liggitt July 13, 2017 17:53

openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2017

openshift-merge-robot assigned mfojtik Jul 25, 2017

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2017

openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017

juanvallejo added the kind/post-rebase label Oct 5, 2017

openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 14, 2017

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch from a932a1f to 5f39bce Compare October 26, 2017 16:04

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2017

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch from 5f39bce to 7790554 Compare October 26, 2017 19:23

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2017

juanvallejo removed the kind/post-rebase label Oct 26, 2017

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch from 7790554 to c2dfbdd Compare October 26, 2017 20:04

juanvallejo changed the title ~~UPSTREAM: 48763: add error message if <rsrc>/<name> pairs are specified w/ --local flag~~ UPSTREAM: 48763: Add Local and Unstructured resource builder attributes and handle <rsrsc> / <name> pairs when --local is set Oct 26, 2017

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch 2 times, most recently from 4ad399e to 477445b Compare October 26, 2017 23:21

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch 2 times, most recently from 6fc0e06 to 0a80a6e Compare October 27, 2017 19:31

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2017

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2017

juanvallejo added 2 commits November 20, 2017 12:02

UPSTREAM: 48763: add err message if <rsrc>/<name> pairs specified w/ …

fcbeb0c

…--local

UPSTREAM: 48763: add Local and Unstructured builder attributes

162776f

Moves DisabledClientMapperForMapping wrapper to new Local attribute. Removes Factory#NewUnstructuredBuilder in favor of new Unstructured builder attribute.

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch from 0a80a6e to 044b8a9 Compare November 20, 2017 17:09

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2017

juanvallejo added 3 commits November 20, 2017 15:51

UPSTREAM: 54506: remove mutual exclusivity check - local, unstructure…

d3a1eb3

…d builder attrs

add err message if <rsrc>/<name> pairs specified w/ --local flag

a4b81e7

add Local and Unstructured builder attributes

445ad72

juanvallejo force-pushed the jvallejo/add-local-set-cmd-err-message branch from 044b8a9 to 445ad72 Compare November 20, 2017 20:51

juanvallejo closed this Dec 6, 2017

Conversation

juanvallejo commented Jul 11, 2017

Uh oh!

juanvallejo commented Jul 11, 2017

Uh oh!

openshift-bot commented Jul 11, 2017

Uh oh!

openshift-bot commented Jul 11, 2017

Uh oh!

juanvallejo commented Jul 11, 2017

Uh oh!

openshift-merge-robot commented Jul 25, 2017

Uh oh!

openshift-merge-robot commented Jul 28, 2017

Uh oh!

juanvallejo commented Oct 27, 2017

Uh oh!

juanvallejo commented Oct 30, 2017

Uh oh!

juanvallejo commented Dec 4, 2017

Uh oh!

juanvallejo commented Dec 4, 2017

Uh oh!

juanvallejo commented Dec 5, 2017

Uh oh!

fabianofranz commented Dec 6, 2017

Uh oh!

juanvallejo commented Dec 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants