Add short TTL cache to token authentication#14916
Merged
openshift-merge-robot merged 5 commits intoopenshift:masterfrom Sep 8, 2017
liggitt:token-cache
Merged
Add short TTL cache to token authentication#14916openshift-merge-robot merged 5 commits intoopenshift:masterfrom liggitt:token-cache
openshift-merge-robot merged 5 commits intoopenshift:masterfrom
liggitt:token-cache
Conversation
liggitt
changed the title
openshift-bot
added
the
needs-rebase
Contributor
Author
|
[test] |
openshift-bot
removed
the
needs-rebase
Contributor
|
[test] |
Contributor
|
Evaluated for origin test up to 61eb559 |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3063/) (Base Commit: 3c5875f) (PR Branch Commit: 61eb559) |
openshift-merge-robot
added
size/L
liggitt
changed the title
openshift-merge-robot
added
size/XL
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
@openshift/sig-security |
openshift-merge-robot
added
the
needs-rebase
Contributor
|
Generally LGTM - a 10s window on either side is not a large deal for a huge reduction in peak load during request storms. |
openshift-merge-robot
added
approved
Contributor
Author
|
upstream commits are merged, any last comments from @openshift/sig-security? do we still want this for 3.6.1? #15662 is ready and green as well |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
|
Automatic merge from submit-queue |
openshift-merge-robot
added a commit
that referenced
this pull request
Sep 9, 2017
Automatic merge from submit-queue 3.6.x: Add short TTL cache to token authentication pick of #14916
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses frequent etcd lookups due to high-volume controllers
Fixes authenticator aspect of https://bugzilla.redhat.com/show_bug.cgi?id=1464579