Fix service IP validation to handle "ClusterIP: None"#13765
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Apr 15, 2017
Merged
Fix service IP validation to handle "ClusterIP: None"#13765openshift-bot merged 1 commit intoopenshift:masterfrom
openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
[test][testextended][extended:networking] |
Contributor
|
[test] again |
danwinship
force-pushed
the
fix-service-validation
branch
from
c618a33 to
575abd8
Compare
Contributor
|
Evaluated for origin test up to 575abd8 |
Contributor
|
Evaluated for origin testextended up to 575abd8 |
Contributor
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/171/) (Base Commit: bf9854f) (Extended Tests: networking) |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/752/) (Base Commit: bf9854f) |
Contributor
|
[merge] please |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/752/) (Base Commit: bf9854f) (Image: devenv-rhel7_6146) |
Contributor
|
Evaluated for origin merge up to 575abd8 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDN master's validateNetworkConfig() (which runs any time the default ClusterNetwork object is about to be changed) doesn't handle services with "ClusterIP: None". So, if you have such a service, and then, say, you try to switch from the multitenant plugin to the networkpolicy plugin, the master won't start.
I have a pending PR to clean up the master startup validation code a bunch, and not die on errors that don't really need to be fatal, but for backporting purposes, let's stick with a simple change for now
@openshift/networking @rajatchopra PTAL